Page MenuHomePhabricator

Remove no-op callbacks from TemplateInstantiationCallback

Authored by gribozavr on Tue, Aug 13, 4:23 AM.



It is not clear to me that these callbacks ever did anything, they were
empty even in the original implementation (r324808).

Event Timeline

gribozavr created this revision.Tue, Aug 13, 4:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Aug 13, 4:23 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

The changes look good to me. Added some folks who might have more knowledge about the original purpose.

Szelethus requested changes to this revision.Tue, Aug 13, 7:19 AM

They are used by Templight, which we are planning to eventually move to clang-tools extra, though our resources are a bit limited at the time :)

This revision now requires changes to proceed.Tue, Aug 13, 7:19 AM
gribozavr abandoned this revision.Tue, Aug 13, 11:37 AM