This is an archive of the discontinued LLVM Phabricator instance.

Differential D66056

Add 2 tests which cover the hover result for auto
Needs ReviewPublic

Authored by puremourning on Aug 10 2019, 8:07 AM.

Details

Reviewers
sammccall
Summary

Clangd supports reporting the deduced type when hovering on 'auto', but
does not report it when hovering on a particular name/decl.

Add two tests which show this behaviour.

Diff Detail

Event Timeline

puremourning created this revision.Aug 10 2019, 8:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2019, 8:07 AM
Herald added subscribers: cfe-commits, kadircet, arphaman and 2 others. · View Herald Transcript
Harbormaster completed remote builds in B36573: Diff 214530.Aug 10 2019, 8:11 AM

Revision Contents

PathSize
clang-tools-extra/
clangd/
test/
44 lines

Diff 214530

clang-tools-extra/clangd/test/hover.test

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
# CHECK-NEXT: "start": { # CHECK-NEXT: "start": {
# CHECK-NEXT: "character": 25, # CHECK-NEXT: "character": 25,
# CHECK-NEXT: "line": 0 # CHECK-NEXT: "line": 0
# CHECK-NEXT: } # CHECK-NEXT: }
# CHECK-NEXT: } # CHECK-NEXT: }
# CHECK-NEXT: } # CHECK-NEXT: }
# CHECK-NEXT:} # CHECK-NEXT:}
--- ---
{"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"uri":"test:///main3.cpp","languageId":"cpp","version":1,"text":"int main() { auto x = 2; }\n"}}}
---
{"jsonrpc":"2.0","id":1,"method":"textDocument/hover","params":{"textDocument":{"uri":"test:///main3.cpp"},"position":{"line":0,"character":18}}}
# CHECK: "id": 1,
# CHECK-NEXT: "jsonrpc": "2.0",
# CHECK-NEXT: "result": {
# CHECK-NEXT: "contents": {
# CHECK-NEXT: "kind": "plaintext",
# CHECK-NEXT: "value": "Declared in main\n\nauto x = 2"
# CHECK-NEXT: },
# CHECK-NEXT: "range": {
# CHECK-NEXT: "end": {
# CHECK-NEXT: "character": 19,
# CHECK-NEXT: "line": 0
# CHECK-NEXT: },
# CHECK-NEXT: "start": {
# CHECK-NEXT: "character": 18,
# CHECK-NEXT: "line": 0
# CHECK-NEXT: }
# CHECK-NEXT: }
# CHECK-NEXT: }
# CHECK-NEXT:}
---
{"jsonrpc":"2.0","id":1,"method":"textDocument/hover","params":{"textDocument":{"uri":"test:///main3.cpp"},"position":{"line":0,"character":15}}}
# CHECK: "id": 1,
# CHECK-NEXT: "jsonrpc": "2.0",
# CHECK-NEXT: "result": {
# CHECK-NEXT: "contents": {
# CHECK-NEXT: "kind": "plaintext",
# CHECK-NEXT: "value": "int"
# CHECK-NEXT: },
# CHECK-NEXT: "range": {
# CHECK-NEXT: "end": {
# CHECK-NEXT: "character": 17,
# CHECK-NEXT: "line": 0
# CHECK-NEXT: },
# CHECK-NEXT: "start": {
# CHECK-NEXT: "character": 13,
# CHECK-NEXT: "line": 0
# CHECK-NEXT: }
# CHECK-NEXT: }
# CHECK-NEXT: }
# CHECK-NEXT:}
---
{"jsonrpc":"2.0","id":3,"method":"shutdown"} {"jsonrpc":"2.0","id":3,"method":"shutdown"}
--- ---
{"jsonrpc":"2.0","method":"exit"} {"jsonrpc":"2.0","method":"exit"}