Page MenuHomePhabricator

puremourning (Ben Jackson)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 22 2015, 6:53 PM (327 w, 2 d)

Recent Activity

Tue, Nov 23

puremourning added a comment to D112222: [LLDB] libcxx summary formatters for std::string_view.

Apologies, this dropped off my radar it LGTM, thank you!

Tue, Nov 23, 10:51 AM · Restricted Project

Fri, Nov 19

puremourning added a comment to D112222: [LLDB] libcxx summary formatters for std::string_view.

Sorry, but is anything further required from me on this patch ?

You addressed an issue Shafik asked you to, so then he should make sure he's happy with the change and mark the patch accepted. OTOH we're all busy so it's easy to let this sort of thing drop. On your end, you should wait a polite interval then issue a gentle ping in his direction... A week is an okay interval, I think, so now would be appropriate.

Fri, Nov 19, 1:06 PM · Restricted Project

Thu, Nov 18

puremourning added a comment to D112222: [LLDB] libcxx summary formatters for std::string_view.

Sorry, but is anything further required from me on this patch ?

Thu, Nov 18, 2:43 PM · Restricted Project

Oct 21 2021

puremourning updated the diff for D112222: [LLDB] libcxx summary formatters for std::string_view.

Add some tests for dodgy inputs.
Handle invalid cases more consistently.
Factor out some copy paste code.

Oct 21 2021, 1:14 PM · Restricted Project
puremourning added a comment to D112222: [LLDB] libcxx summary formatters for std::string_view.

It looks good to me but can we verify it behaves nicely with undefined behavior cases e.g.:

std::string s = "Hellooooooooooooooo ";
std::string_view sv = s + "World\n";
Oct 21 2021, 12:18 PM · Restricted Project
puremourning updated the diff for D112222: [LLDB] libcxx summary formatters for std::string_view.

Revert some formatting lost in rebase

Oct 21 2021, 12:11 PM · Restricted Project
puremourning added a comment to D112222: [LLDB] libcxx summary formatters for std::string_view.

Thanks for the review!

Oct 21 2021, 11:46 AM · Restricted Project
puremourning updated the diff for D112222: [LLDB] libcxx summary formatters for std::string_view.

Use expect_var_path rather than just expect in test

Oct 21 2021, 11:44 AM · Restricted Project
puremourning updated the diff for D112222: [LLDB] libcxx summary formatters for std::string_view.

RE-post with clang-format in path

Oct 21 2021, 9:19 AM · Restricted Project
puremourning updated the diff for D112222: [LLDB] libcxx summary formatters for std::string_view.

Remove change to the formatting of empty u16 and u32 strings

Oct 21 2021, 9:17 AM · Restricted Project
puremourning added a comment to D112222: [LLDB] libcxx summary formatters for std::string_view.

I would actually prefer if we could split this into a separate change :) (Sorry!)

Oct 21 2021, 8:25 AM · Restricted Project
puremourning added a comment to D112222: [LLDB] libcxx summary formatters for std::string_view.

I'm happy to revert/split out the change for empty strings, as this is perhaps contentious (and not exactly minimal for this patch).

Oct 21 2021, 7:57 AM · Restricted Project
puremourning added a reviewer for D112222: [LLDB] libcxx summary formatters for std::string_view: jingham.
Oct 21 2021, 7:55 AM · Restricted Project
puremourning requested review of D112222: [LLDB] libcxx summary formatters for std::string_view.
Oct 21 2021, 7:54 AM · Restricted Project

May 21 2021

puremourning added a comment to D93565: scan-view: Remove Reporter.py and associated AppleScript files.

Erm, doh. I thought I was on main, but I was using clang 12.0.0 (tag llvmorg-12.0.0 from llvm-project). We tend to only use release tagged versions.

May 21 2021, 7:35 AM · Restricted Project

May 20 2021

puremourning added a comment to D93565: scan-view: Remove Reporter.py and associated AppleScript files.

Unless i'm missing something, this change seems to have broken scan-view, as it now just says

"ModuleNotFOundError: No module named 'Reporter'"

Due to :

import Reporter in ScanView.py

Am i losing my mind?

May 20 2021, 3:33 AM · Restricted Project
puremourning added a comment to D93565: scan-view: Remove Reporter.py and associated AppleScript files.

Unless i'm missing something, this change seems to have broken scan-view, as it now just says

May 20 2021, 3:30 AM · Restricted Project

Jan 3 2020

puremourning created D72152: Support Launching in External Console in lldb-vscode.
Jan 3 2020, 6:47 AM · Restricted Project

Aug 14 2019

puremourning added a comment to D66254: Correct include suggestion when search path includes symlink.

Tests?

Per my comment: I haven't added new tests to HeaderSearchTest.cc because the InMemoryFileSystem doesn't support symlinks and I didn't want to try and implement that for this patch. Let me know thoughts on alternative ways to regression test it.

Aug 14 2019, 2:21 PM · Restricted Project
puremourning added a comment to D66254: Correct include suggestion when search path includes symlink.

Tests?

Aug 14 2019, 2:13 PM · Restricted Project
puremourning added a comment to D66254: Correct include suggestion when search path includes symlink.

FYI this fixes the issue in https://github.com/clangd/clangd/issues/124

Aug 14 2019, 1:57 PM · Restricted Project
puremourning created D66254: Correct include suggestion when search path includes symlink.
Aug 14 2019, 1:57 PM · Restricted Project

Aug 10 2019

puremourning created D66056: Add 2 tests which cover the hover result for auto.
Aug 10 2019, 8:11 AM · Restricted Project

Aug 9 2019

puremourning added a comment to D66038: [Support] heavyweight_hardware_concurrency uses affinity when counting cores fails, and never returns 0.

LGTM :)

Aug 9 2019, 4:00 PM · Restricted Project, Restricted Project
puremourning added a comment to D66031: clangd: use -j for background index pool.

Thanks! Want me to land this for you?

Aug 9 2019, 3:49 PM · Restricted Project, Restricted Project
puremourning updated the diff for D66031: clangd: use -j for background index pool.

Rebase on master

Aug 9 2019, 3:22 PM · Restricted Project, Restricted Project
puremourning added inline comments to D66031: clangd: use -j for background index pool.
Aug 9 2019, 3:16 PM · Restricted Project, Restricted Project
puremourning updated the diff for D66031: clangd: use -j for background index pool.

Always use physical cores rather than logical cores for best performance.

Aug 9 2019, 3:13 PM · Restricted Project, Restricted Project
puremourning added inline comments to D66031: clangd: use -j for background index pool.
Aug 9 2019, 2:44 PM · Restricted Project, Restricted Project
puremourning updated the diff for D66031: clangd: use -j for background index pool.

When -sync -background-index supplied, use 1 thread for background index.

Aug 9 2019, 2:44 PM · Restricted Project, Restricted Project
puremourning created D66031: clangd: use -j for background index pool.
Aug 9 2019, 2:00 PM · Restricted Project, Restricted Project

Sep 4 2017

puremourning added a comment to D37282: clangd: Tolerate additional headers.

Looks good and ready to land. Thanks for this change.
Do you have commit rights to llvm repo?

Sep 4 2017, 4:43 AM

Sep 2 2017

puremourning added a comment to D37282: clangd: Tolerate additional headers.

So I think this is ready now. Anything more you need from me?

Sep 2 2017, 10:14 AM

Aug 31 2017

puremourning updated the diff for D37282: clangd: Tolerate additional headers.

Validate that the duplicate message is printed.

Aug 31 2017, 2:34 PM
puremourning updated subscribers of D37282: clangd: Tolerate additional headers.
Aug 31 2017, 2:15 PM
puremourning updated the diff for D37282: clangd: Tolerate additional headers.

Tidy logging: missing newlines.

Aug 31 2017, 2:09 PM
puremourning updated the diff for D37282: clangd: Tolerate additional headers.

Keep ContentLength within the loop by using an inner loop to read headers.
Update tests to check stderr correctly.
Add some useful diagnostics to the log.

Aug 31 2017, 2:06 PM

Aug 30 2017

puremourning added a comment to D37282: clangd: Tolerate additional headers.

Thanks for the review! Few quick responses.

Aug 30 2017, 5:35 AM

Aug 29 2017

puremourning created D37282: clangd: Tolerate additional headers.
Aug 29 2017, 4:09 PM

Jul 11 2016

puremourning added a comment to D22129: [clang-rename] add documentation.

Couple of drive-by comments. Thanks for doing this.

Jul 11 2016, 3:19 PM

Aug 22 2015

puremourning added a comment to D11976: [libclang] Return deduced type for auto type, not the one written in the source..

I can confirm that this patch fixes a number test cases found in ycmd (a code-completion server). Specifically these ones marked as 'sic'

Aug 22 2015, 7:16 PM