- User Since
- Aug 22 2015, 6:53 PM (327 w, 2 d)
Tue, Nov 23
Fri, Nov 19
Thu, Nov 18
Sorry, but is anything further required from me on this patch ?
Oct 21 2021
Add some tests for dodgy inputs.
Handle invalid cases more consistently.
Factor out some copy paste code.
Revert some formatting lost in rebase
Thanks for the review!
Use expect_var_path rather than just expect in test
RE-post with clang-format in path
Remove change to the formatting of empty u16 and u32 strings
I would actually prefer if we could split this into a separate change :) (Sorry!)
I'm happy to revert/split out the change for empty strings, as this is perhaps contentious (and not exactly minimal for this patch).
May 21 2021
Erm, doh. I thought I was on main, but I was using clang 12.0.0 (tag llvmorg-12.0.0 from llvm-project). We tend to only use release tagged versions.
May 20 2021
Unless i'm missing something, this change seems to have broken scan-view, as it now just says
Jan 3 2020
Aug 14 2019
FYI this fixes the issue in https://github.com/clangd/clangd/issues/124
Aug 10 2019
Aug 9 2019
Rebase on master
Always use physical cores rather than logical cores for best performance.
When -sync -background-index supplied, use 1 thread for background index.
Sep 4 2017
Sep 2 2017
So I think this is ready now. Anything more you need from me?
Aug 31 2017
Validate that the duplicate message is printed.
Tidy logging: missing newlines.
Keep ContentLength within the loop by using an inner loop to read headers.
Update tests to check stderr correctly.
Add some useful diagnostics to the log.
Aug 30 2017
Thanks for the review! Few quick responses.
Aug 29 2017
Jul 11 2016
Couple of drive-by comments. Thanks for doing this.