This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly][lld] control __data_end export with config->shared
ClosedPublic

Authored by quantum on Aug 8 2019, 3:20 PM.

Details

Summary

Emscripten expects __data_end to show up in PIC code as long as it's not
linked with --shared.

Currently, Emscripten breaks with latest LLVM because __data_end is controlled
by config->isPic instead of config->shared.`

Diff Detail

Repository
rL LLVM

Event Timeline

quantum created this revision.Aug 8 2019, 3:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2019, 3:20 PM
sbc100 accepted this revision.Aug 8 2019, 3:35 PM
Great thanks.  Sorry I overlooked that in my last change.   Ideally we shouldn't be making this available in `-pie` either but for restoring the previous behaviour seems reasonable.
lld/wasm/Driver.cpp
530 ↗(On Diff #214247)

Remove the curlies

This revision is now accepted and ready to land.Aug 8 2019, 3:35 PM
quantum updated this revision to Diff 214249.Aug 8 2019, 3:38 PM

Remove the curlies.

quantum marked an inline comment as done.Aug 8 2019, 3:38 PM
This revision was automatically updated to reflect the committed changes.