Page MenuHomePhabricator

[clang] Fixed x86 cpuid NSC signature
ClosedPublic

Authored by Jacotot on Aug 8 2019, 2:56 PM.

Details

Summary

The signature "Geode by NSC" for NSC vendor is wrong.
In lib/Headers/cpuid.h, signature_NSC_edx and signature_NSC_ecx constants are inverted (cpuid signature order is ebx # edx # ecx).

Diff Detail

Repository
rL LLVM

Event Timeline

Jacotot created this revision.Aug 8 2019, 2:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2019, 2:56 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
craig.topper accepted this revision.Aug 8 2019, 3:32 PM
craig.topper added a subscriber: craig.topper.

LGTM

This revision is now accepted and ready to land.Aug 8 2019, 3:32 PM

@Jacotot I assume you don't have commit access to merge yourself?

@Jacotot I assume you don't have commit access to merge yourself?

I don't : this is my very first contribution to the project

teemperor accepted this revision.Aug 10 2019, 3:12 AM

LGTM. Thanks for the patch!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2019, 3:13 AM