This is an archive of the discontinued LLVM Phabricator instance.

Differential D65978

[clang] Fixed x86 cpuid NSC signature
ClosedPublic

Authored by Jacotot on Aug 8 2019, 2:56 PM.

Details

Reviewers
teemperor
rsmith
craig.topper
Commits
rGc4b5b66a05bb: [clang] Fixed x86 cpuid NSC signature
rL368510: [clang] Fixed x86 cpuid NSC signature
rC368510: [clang] Fixed x86 cpuid NSC signature
Summary

The signature "Geode by NSC" for NSC vendor is wrong.
In lib/Headers/cpuid.h, signature_NSC_edx and signature_NSC_ecx constants are inverted (cpuid signature order is ebx # edx # ecx).

Diff Detail

Repository
rL LLVM

Event Timeline

Jacotot created this revision.Aug 8 2019, 2:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2019, 2:56 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
craig.topper accepted this revision.Aug 8 2019, 3:32 PM
craig.topper added a subscriber: craig.topper.

LGTM

This revision is now accepted and ready to land.Aug 8 2019, 3:32 PM
teemperor added a comment.Aug 10 2019, 1:57 AM

@Jacotot I assume you don't have commit access to merge yourself?

Jacotot added a comment.Aug 10 2019, 2:29 AM
In D65978#1624220, @teemperor wrote:

@Jacotot I assume you don't have commit access to merge yourself?

I don't : this is my very first contribution to the project

teemperor accepted this revision.Aug 10 2019, 3:12 AM

LGTM. Thanks for the patch!

Closed by commit rL368510: [clang] Fixed x86 cpuid NSC signature (authored by teemperor). · Explain WhyAug 10 2019, 3:13 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2019, 3:13 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
cfe/
trunk/
lib/
Headers/
4 lines

Diff 214516

cfe/trunk/lib/Headers/cpuid.h

Show All 32 Lines
#define signature_TM1_edx 0x74656d73 #define signature_TM1_edx 0x74656d73
#define signature_TM1_ecx 0x55504361 #define signature_TM1_ecx 0x55504361
/* TM2: "GenuineTMx86" */ /* TM2: "GenuineTMx86" */
#define signature_TM2_ebx 0x756e6547 #define signature_TM2_ebx 0x756e6547
#define signature_TM2_edx 0x54656e69 #define signature_TM2_edx 0x54656e69
#define signature_TM2_ecx 0x3638784d #define signature_TM2_ecx 0x3638784d
/* NSC: "Geode by NSC" */ /* NSC: "Geode by NSC" */
#define signature_NSC_ebx 0x646f6547 #define signature_NSC_ebx 0x646f6547
#define signature_NSC_edx 0x43534e20 #define signature_NSC_edx 0x79622065
#define signature_NSC_ecx 0x79622065 #define signature_NSC_ecx 0x43534e20
/* NEXGEN: "NexGenDriven" */ /* NEXGEN: "NexGenDriven" */
#define signature_NEXGEN_ebx 0x4778654e #define signature_NEXGEN_ebx 0x4778654e
#define signature_NEXGEN_edx 0x72446e65 #define signature_NEXGEN_edx 0x72446e65
#define signature_NEXGEN_ecx 0x6e657669 #define signature_NEXGEN_ecx 0x6e657669
/* RISE: "RiseRiseRise" */ /* RISE: "RiseRiseRise" */
#define signature_RISE_ebx 0x65736952 #define signature_RISE_ebx 0x65736952
#define signature_RISE_edx 0x65736952 #define signature_RISE_edx 0x65736952
#define signature_RISE_ecx 0x65736952 #define signature_RISE_ecx 0x65736952
▲ Show 20 Lines • Show All 252 Lines • Show Last 20 Lines