This is an archive of the discontinued LLVM Phabricator instance.

[clang][NFC] Consolidating usage of "FinalPhase" in Driver::BuildActions
ClosedPublic

Authored by plotfi on Aug 8 2019, 1:28 PM.

Details

Summary

I am working to remove this concept of the "FinalPhase" in the clang driver, but it is used in a lot of different places to do argument handling for different combinatios of phase pipelines and arguments. I am trying to consolidate most of the uses of "FinalPhase" into its own separate scope.

Diff Detail

Event Timeline

plotfi created this revision.Aug 8 2019, 1:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2019, 1:28 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
plotfi updated this revision to Diff 214222.Aug 8 2019, 1:37 PM

adding context

compnerd accepted this revision.Aug 8 2019, 2:13 PM

Seems like it should be equivalent.

This revision is now accepted and ready to land.Aug 8 2019, 2:13 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2019, 9:56 PM