This is an archive of the discontinued LLVM Phabricator instance.

Differential D65965

[lldb] Fix HAVE_LIBCOMPRESSION
ClosedPublic

Authored by hhb on Aug 8 2019, 12:33 PM.

Details

Reviewers
labath
JDevlieghere
Commits
rG7debc93afc18: [lldb] Fix HAVE_LIBCOMPRESSION
rL368352: [lldb] Fix HAVE_LIBCOMPRESSION
rLLDB368352: [lldb] Fix HAVE_LIBCOMPRESSION
Summary

This test doesn't make sense. Change to be consistent with what we did
in GDBRemoteCommunication.cpp.

Diff Detail

Event Timeline

hhb created this revision.Aug 8 2019, 12:33 PM
Herald added a subscriber: lldb-commits. · View Herald TranscriptAug 8 2019, 12:33 PM
Harbormaster completed remote builds in B36454: Diff 214211.Aug 8 2019, 12:34 PM
hhb updated this revision to Diff 214212.Aug 8 2019, 12:37 PM

And we should really include Config.h

Harbormaster completed remote builds in B36455: Diff 214212.Aug 8 2019, 12:37 PM
JDevlieghere accepted this revision.Aug 8 2019, 1:22 PM
This revision is now accepted and ready to land.Aug 8 2019, 1:22 PM
Closed by commit rL368352: [lldb] Fix HAVE_LIBCOMPRESSION (authored by hhb). · Explain WhyAug 8 2019, 2:41 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2019, 2:41 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
lldb/
source/
Plugins/
Process/
gdb-remote/
5 lines

Diff 214211

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

Show All 30 Lines
#include "ProcessGDBRemote.h" #include "ProcessGDBRemote.h"
#include "ProcessGDBRemoteLog.h" #include "ProcessGDBRemoteLog.h"
#include "lldb/Host/Config.h" #include "lldb/Host/Config.h"
#include "lldb/Utility/StringExtractorGDBRemote.h" #include "lldb/Utility/StringExtractorGDBRemote.h"
#include "llvm/ADT/StringSwitch.h" #include "llvm/ADT/StringSwitch.h"
#if defined(__APPLE__) #if defined(HAVE_LIBCOMPRESSION)
#ifndef HAVE_LIBCOMPRESSION
#define HAVE_LIBCOMPRESSION
#endif
#include <compression.h> #include <compression.h>
#endif #endif
using namespace lldb; using namespace lldb;
using namespace lldb_private; using namespace lldb_private;
using namespace lldb_private::process_gdb_remote; using namespace lldb_private::process_gdb_remote;
using namespace std::chrono; using namespace std::chrono;
▲ Show 20 Lines • Show All 3,953 Lines • Show Last 20 Lines