Page MenuHomePhabricator

[ORC] FIxed warning on Windows about deprecated ORCv1
AbandonedPublic

Authored by lhames on Aug 8 2019, 3:04 AM.

Details

Summary

Building with MSVC 2017 there was a warning raised about deprecated ORCv1.
Turned out that there was a missing 'AcknowledgeORCv1Deprecation' parameter in emplace_back call.

Diff Detail

Event Timeline

ivankara created this revision.Aug 8 2019, 3:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2019, 3:04 AM

Can anyone review this?

Right, this was a missing deprecation change. Thanks for posting! Lang fixed it the same day, so I guess we can abandon this review.

lhames commandeered this revision.Sep 24 2019, 9:49 AM
lhames edited reviewers, added: ivankara; removed: lhames.

Yep — this can be abandoned.

lhames abandoned this revision.Sep 24 2019, 9:49 AM