Page MenuHomePhabricator

GlobalISel: pack various parameters for lowerCall into a struct.
ClosedPublic

Authored by t.p.northover on Wed, Aug 7, 1:43 AM.

Details

Reviewers
aemerson
Summary

I've now needed to add an extra parameter to this call twice recently. Not only is the signature getting extremely unwieldy, but just updating all of the callsites and implementations is a pain. Putting the parameters in a struct sidesteps both issues.

Diff Detail

Event Timeline

t.p.northover created this revision.Wed, Aug 7, 1:43 AM
aemerson accepted this revision.Wed, Aug 7, 8:33 PM

LGTM

This revision is now accepted and ready to land.Wed, Aug 7, 8:33 PM
aemerson closed this revision.Mon, Aug 19, 10:36 AM

Closing as committed.