This is an archive of the discontinued LLVM Phabricator instance.

[docs][mips] 9.0 Release notes
ClosedPublic

Authored by atanasyan on Aug 6 2019, 2:09 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

atanasyan created this revision.Aug 6 2019, 2:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2019, 2:09 PM
hans added inline comments.Aug 7 2019, 1:37 AM
lld/docs/ReleaseNotes.rst
31 ↗(On Diff #213718)

Should it be *replaced* JAL *with* JALX ...?

33 ↗(On Diff #213718)

Should it be *creates*?

llvm/docs/ReleaseNotes.rst
120 ↗(On Diff #213718)

But is it supported yet, or still experimental? Might be worth a short note in case readers are wondering.

atanasyan updated this revision to Diff 213861.Aug 7 2019, 6:17 AM
  • Fix grammar errors.
  • Add details for the MIPS GlobalISel note.
This revision is now accepted and ready to land.Aug 7 2019, 8:16 AM
hans accepted this revision.Aug 7 2019, 9:31 AM

lgtm

Let me know if you want me to commit to the release branch for you.

Thanks for review. Hans, could you please commit this patch? I'm not sure that I know how to commit to the not-master branch in the monorepo repository.

This revision was automatically updated to reflect the committed changes.
hans added a comment.Aug 9 2019, 1:37 AM

Thanks for review. Hans, could you please commit this patch? I'm not sure that I know how to commit to the not-master branch in the monorepo repository.

Committed in r368411 (llvm side) and r368412 (lld).