This is an archive of the discontinued LLVM Phabricator instance.

Differential D65791

[X86] Move CPU features for Barcelona/K10 out of line
ClosedPublic

Authored by lebedev.ri on Aug 6 2019, 1:42 AM.

Details

Reviewers
craig.topper
RKSimon
Commits
rG213817327f69: [X86] Move CPU features for Barcelona/K10 out of line
rL368061: [X86] Move CPU features for Barcelona/K10 out of line
Summary

Cleans X86.td's Barcelona entry to be more like the others,
by moving the features out of the Proc<>, thus potentially
making it possible to inherit from them.
Split off from D63628

Diff Detail

Event Timeline

lebedev.ri created this revision.Aug 6 2019, 1:42 AM
Herald added subscribers: jfb, hiraditya. · View Herald TranscriptAug 6 2019, 1:42 AM
lebedev.ri mentioned this in D63628: AMD K10 (Barcelona) Initial Scheduler model.Aug 6 2019, 1:43 AM
lebedev.ri added a child revision: D63628: AMD K10 (Barcelona) Initial Scheduler model.
craig.topper accepted this revision.Aug 6 2019, 9:41 AM

LGTM

This revision is now accepted and ready to land.Aug 6 2019, 9:41 AM
Closed by commit rL368061: [X86] Move CPU features for Barcelona/K10 out of line (authored by lebedevri). · Explain WhyAug 6 2019, 10:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Target/
X86/
21 lines

Diff 213534

llvm/lib/Target/X86/X86.td

Show First 20 Lines • Show All 780 Lines • ▼ Show 20 Lines list<SubtargetFeature> KNLFeatures = [FeatureX87,
FeatureSlowTwoMemOps, FeatureSlowTwoMemOps,
FeatureFastPartialYMMorZMMWrite, FeatureFastPartialYMMorZMMWrite,
FeatureHasFastGather, FeatureHasFastGather,
FeatureSlowPMADDWD]; FeatureSlowPMADDWD];
// TODO Add AVX5124FMAPS/AVX5124VNNIW features // TODO Add AVX5124FMAPS/AVX5124VNNIW features
list<SubtargetFeature> KNMFeatures = list<SubtargetFeature> KNMFeatures =
!listconcat(KNLFeatures, [FeatureVPOPCNTDQ]); !listconcat(KNLFeatures, [FeatureVPOPCNTDQ]);
// Barcelona
list<SubtargetFeature> BarcelonaInheritableFeatures = [FeatureX87,
FeatureCMPXCHG8B,
FeatureSSE4A,
Feature3DNowA,
FeatureFXSR,
FeatureNOPL,
FeatureCMPXCHG16B,
FeatureLZCNT,
FeaturePOPCNT,
FeatureSlowSHLD,
FeatureLAHFSAHF,
FeatureCMOV,
Feature64Bit,
FeatureFastScalarShiftMasks];
list<SubtargetFeature> BarcelonaFeatures = BarcelonaInheritableFeatures;
// Bobcat // Bobcat
list<SubtargetFeature> BtVer1InheritableFeatures = [FeatureX87, list<SubtargetFeature> BtVer1InheritableFeatures = [FeatureX87,
FeatureCMPXCHG8B, FeatureCMPXCHG8B,
FeatureCMOV, FeatureCMOV,
FeatureMMX, FeatureMMX,
FeatureSSSE3, FeatureSSSE3,
FeatureSSE4A, FeatureSSE4A,
▲ Show 20 Lines • Show All 327 Lines • ▼ Show 20 Lines
foreach P = ["k8-sse3", "opteron-sse3", "athlon64-sse3"] in { foreach P = ["k8-sse3", "opteron-sse3", "athlon64-sse3"] in {
def : Proc<P, [FeatureX87, FeatureSlowUAMem16, FeatureCMPXCHG8B, FeatureSSE3, def : Proc<P, [FeatureX87, FeatureSlowUAMem16, FeatureCMPXCHG8B, FeatureSSE3,
Feature3DNowA, FeatureFXSR, FeatureNOPL, FeatureCMPXCHG16B, Feature3DNowA, FeatureFXSR, FeatureNOPL, FeatureCMPXCHG16B,
FeatureSlowSHLD, FeatureCMOV, Feature64Bit, FeatureSlowSHLD, FeatureCMOV, Feature64Bit,
FeatureFastScalarShiftMasks]>; FeatureFastScalarShiftMasks]>;
} }
foreach P = ["amdfam10", "barcelona"] in { foreach P = ["amdfam10", "barcelona"] in {
def : Proc<P, [FeatureX87, FeatureCMPXCHG8B, FeatureSSE4A, Feature3DNowA, def : Proc<P, ProcessorFeatures.BarcelonaFeatures>;
FeatureFXSR, FeatureNOPL, FeatureCMPXCHG16B, FeatureLZCNT,
FeaturePOPCNT, FeatureSlowSHLD, FeatureLAHFSAHF, FeatureCMOV,
Feature64Bit, FeatureFastScalarShiftMasks]>;
} }
// Bobcat // Bobcat
def : Proc<"btver1", ProcessorFeatures.BtVer1Features>; def : Proc<"btver1", ProcessorFeatures.BtVer1Features>;
// Jaguar // Jaguar
def : ProcessorModel<"btver2", BtVer2Model, ProcessorFeatures.BtVer2Features>; def : ProcessorModel<"btver2", BtVer2Model, ProcessorFeatures.BtVer2Features>;
// Bulldozer // Bulldozer
▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines