Page MenuHomePhabricator

[llvm-ar][test] Correct tests marked as expected fails
ClosedPublic

Authored by gbreynoo on Aug 5 2019, 6:58 AM.

Details

Summary

In diff D64802 I marked three tests as expected failures for darwin but James Nagurne saw these fail on his downstream embedded ARM cross compiler.
I believe XFAIL: system-darwin should be used instead of using XFAIL: darwin due to the problem being related to the darwin host and not the target.

Diff Detail

Repository
rL LLVM

Event Timeline

gbreynoo created this revision.Aug 5 2019, 6:58 AM
JamesNagurne accepted this revision.Aug 5 2019, 8:42 AM

Our team independently applied and validated this change for our ARM cross compiler running on darwin, and we shared the same failure modes as the darwin compiler. I feel that this is sufficient evidence that the bug is related to the host, not the target.

This revision is now accepted and ready to land.Aug 5 2019, 8:42 AM
MaskRay accepted this revision.Aug 5 2019, 6:48 PM
This revision was automatically updated to reflect the committed changes.