Page MenuHomePhabricator

[lldb][clang] Reflect LangStandard.h move to clang/Basic
ClosedPublic

Authored by ro on Aug 4 2019, 3:26 AM.

Details

Summary

D65562 moves LangStandard.h from clang/Frontend to clang/Basic. This patch
adjusts the single file in lldb that uses it to match.

Tested on x86_64-pc-linux-gnu. Ok for trunk?

One thing I'm unsure about is the scenario of building lldb with an existing (pre-Langstandard.h move)
clang: is this supposed to work in the general case and if so, how to deal with the two
possible paths for the header? I couldn't find an example of this in lldb.

Diff Detail

Repository
rL LLVM

Event Timeline

ro created this revision.Aug 4 2019, 3:26 AM
labath accepted this revision.Aug 5 2019, 12:38 AM
labath added a subscriber: labath.

building lldb with an existing (pre-Langstandard.h move)
clang: is this supposed to work in the general case

No, this isn't something that is supposed to work in the general case. master LLDB builds only with master clang. Sometimes you might be able to get away with using a slightly older (~a week) clang or llvm (I do to cut down on build times), but that is a totally unsupported thing...

This revision is now accepted and ready to land.Aug 5 2019, 12:38 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2019, 7:07 AM