The new scheme is similar to the pass manager and dyn_cast scheme where
we identify classes by the address of a static member. This is better
than the old scheme in which we had to "invent" new Attributor enums if
there was no corresponding one.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
To use the address as their id seems very reasonable.
I think we need to modify some comments which refer to AAType::ID.
Otherwise, LGTM.
llvm/include/llvm/Transforms/IPO/Attributor.h | ||
---|---|---|
226 ↗ | (On Diff #213225) | "default attribute kind" to "attribute id" or something like that. |
281 ↗ | (On Diff #213225) | "attribute kinds(Attribute::AttrKind) " to "attribute id(AAType::ID)" or something like that. |