This is an archive of the discontinued LLVM Phabricator instance.

Differential D65669

[CMake] Add mapping for IBM XL -qnoeh and -qnortti
ClosedPublic

Authored by hubert.reinterpretcast on Aug 2 2019, 11:29 AM.

Details

Reviewers
daltenty
xingxue
jasonliu
Commits
rG51b0032ff701: [CMake] Add mapping for IBM XL -qnoeh and -qnortti
rL368050: [CMake] Add mapping for IBM XL -qnoeh and -qnortti
Summary

This patch maps in the -qnoeh and -qnortti options for building with IBM XL compilers.

Diff Detail

Repository
rL LLVM

Event Timeline

hubert.reinterpretcast created this revision.Aug 2 2019, 11:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2019, 11:29 AM
Herald added a subscriber: mgorny. · View Herald Transcript
Harbormaster completed remote builds in B36045: Diff 213096.Aug 2 2019, 11:29 AM
hubert.reinterpretcast updated this revision to Diff 213097.Aug 2 2019, 11:34 AM

Remove accidentally added empty directories.

Harbormaster completed remote builds in B36046: Diff 213097.Aug 2 2019, 11:34 AM
daltenty accepted this revision.Aug 6 2019, 6:01 AM

LGTM

This revision is now accepted and ready to land.Aug 6 2019, 6:01 AM
Closed by commit rL368050: [CMake] Add mapping for IBM XL -qnoeh and -qnortti (authored by hubert.reinterpretcast). · Explain WhyAug 6 2019, 8:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
cmake/
modules/
4 lines

Diff 213619

llvm/trunk/cmake/modules/AddLLVM.cmake

Show All 22 Lines if(LLVM_COMPILER_IS_GCC_COMPATIBLE)
list(APPEND LLVM_COMPILE_FLAGS "-fno-exceptions") list(APPEND LLVM_COMPILE_FLAGS "-fno-exceptions")
if(NOT LLVM_ENABLE_UNWIND_TABLES) if(NOT LLVM_ENABLE_UNWIND_TABLES)
list(APPEND LLVM_COMPILE_FLAGS "-fno-unwind-tables") list(APPEND LLVM_COMPILE_FLAGS "-fno-unwind-tables")
list(APPEND LLVM_COMPILE_FLAGS "-fno-asynchronous-unwind-tables") list(APPEND LLVM_COMPILE_FLAGS "-fno-asynchronous-unwind-tables")
endif() endif()
elseif(MSVC) elseif(MSVC)
list(APPEND LLVM_COMPILE_DEFINITIONS _HAS_EXCEPTIONS=0) list(APPEND LLVM_COMPILE_DEFINITIONS _HAS_EXCEPTIONS=0)
list(APPEND LLVM_COMPILE_FLAGS "/EHs-c-") list(APPEND LLVM_COMPILE_FLAGS "/EHs-c-")
elseif (CMAKE_CXX_COMPILER_ID MATCHES "XL")
list(APPEND LLVM_COMPILE_FLAGS "-qnoeh")
endif() endif()
endif() endif()
# LLVM_REQUIRES_RTTI is an internal flag that individual # LLVM_REQUIRES_RTTI is an internal flag that individual
# targets can use to force RTTI # targets can use to force RTTI
set(LLVM_CONFIG_HAS_RTTI YES CACHE INTERNAL "") set(LLVM_CONFIG_HAS_RTTI YES CACHE INTERNAL "")
if(NOT (LLVM_REQUIRES_RTTI OR LLVM_ENABLE_RTTI)) if(NOT (LLVM_REQUIRES_RTTI OR LLVM_ENABLE_RTTI))
set(LLVM_CONFIG_HAS_RTTI NO CACHE INTERNAL "") set(LLVM_CONFIG_HAS_RTTI NO CACHE INTERNAL "")
list(APPEND LLVM_COMPILE_DEFINITIONS GTEST_HAS_RTTI=0) list(APPEND LLVM_COMPILE_DEFINITIONS GTEST_HAS_RTTI=0)
if (LLVM_COMPILER_IS_GCC_COMPATIBLE) if (LLVM_COMPILER_IS_GCC_COMPATIBLE)
list(APPEND LLVM_COMPILE_FLAGS "-fno-rtti") list(APPEND LLVM_COMPILE_FLAGS "-fno-rtti")
elseif (MSVC) elseif (MSVC)
list(APPEND LLVM_COMPILE_FLAGS "/GR-") list(APPEND LLVM_COMPILE_FLAGS "/GR-")
elseif (CMAKE_CXX_COMPILER_ID MATCHES "XL")
list(APPEND LLVM_COMPILE_FLAGS "-qnortti")
endif () endif ()
elseif(MSVC) elseif(MSVC)
list(APPEND LLVM_COMPILE_FLAGS "/GR") list(APPEND LLVM_COMPILE_FLAGS "/GR")
endif() endif()
# Assume that; # Assume that;
# - LLVM_COMPILE_FLAGS is list. # - LLVM_COMPILE_FLAGS is list.
# - PROPERTY COMPILE_FLAGS is string. # - PROPERTY COMPILE_FLAGS is string.
▲ Show 20 Lines • Show All 1,752 Lines • Show Last 20 Lines