This is an archive of the discontinued LLVM Phabricator instance.

[lldb][NFC] Remove unused imports from Python tests
ClosedPublic

Authored by teemperor on Aug 1 2019, 5:45 AM.

Details

Summary

The python tests have quite a few unused imports to the standard library that don't add anything to the test beside
making them more verbose (and apparently also slower according to the Python wiki).

This patch removes all unused standard library imports by just running autoflake over them.

Diff Detail

Event Timeline

teemperor created this revision.Aug 1 2019, 5:45 AM
Herald added a project: Restricted Project. · View Herald Transcript
labath accepted this revision.Aug 1 2019, 5:48 AM

I haven't looked at all files, but the changes are pretty straight-forward, and bound to break in a pretty obvious way if this is wrong, so LGTM.

This revision is now accepted and ready to land.Aug 1 2019, 5:48 AM
JDevlieghere accepted this revision.Aug 1 2019, 4:40 PM
teemperor closed this revision.Aug 2 2019, 4:38 AM

This has landed in sv as 367663 but it seems Phabricator struggles with this huge patch (as did git-llvm...).