This is an archive of the discontinued LLVM Phabricator instance.

Differential D65527

Avoid assemble step in verbose-output-quoting.c
ClosedPublic

Authored by ychen on Jul 31 2019, 11:33 AM.

Details

Reviewers
hans
Commits
rGe6b26f2f91a3: Avoid assemble step in verbose-output-quoting.c
rC370928: Avoid assemble step in verbose-output-quoting.c
rL370928: Avoid assemble step in verbose-output-quoting.c

Diff Detail

Event Timeline

ychen created this revision.Jul 31 2019, 11:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2019, 11:33 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B35905: Diff 212632.Jul 31 2019, 11:33 AM
hans added a comment.Aug 1 2019, 1:28 AM

Sorry, I should have caught this in the original review.

Normally tests in Driver/ use the -### flag. That way it doesn't invoke the frontend at all, it just shows how it would invoke it. Would that work for this test also?

ychen updated this revision to Diff 218588.Sep 3 2019, 9:49 PM

Address comment.

ychen added a comment.Sep 3 2019, 9:50 PM

Would that work for this test also?

Yes, that sounds good.

Harbormaster completed remote builds in B37689: Diff 218588.Sep 3 2019, 9:50 PM
hans accepted this revision.Sep 4 2019, 1:27 AM

Looks good to me. Thanks!

This revision is now accepted and ready to land.Sep 4 2019, 1:27 AM
Closed by commit rL370928: Avoid assemble step in verbose-output-quoting.c (authored by yuanfang). · Explain WhySep 4 2019, 10:10 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 4 2019, 10:10 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
test/
Driver/
8 lines

Diff 212632

clang/test/Driver/verbose-output-quoting.c

// REQUIRES: shell // REQUIRES: shell
// RUN: %clang --verbose -DSPACE="a b" -c %s 2>&1 | FileCheck -check-prefix=SPACE -strict-whitespace %s // RUN: %clang --verbose -DSPACE="a b" -S %s 2>&1 | FileCheck -check-prefix=SPACE -strict-whitespace %s
// RUN: %clang --verbose -DQUOTES=\"\" -c %s 2>&1 | FileCheck -check-prefix=QUOTES -strict-whitespace %s // RUN: %clang --verbose -DQUOTES=\"\" -S %s 2>&1 | FileCheck -check-prefix=QUOTES -strict-whitespace %s
// RUN: %clang --verbose -DBACKSLASH=\\ -c %s 2>&1 | FileCheck -check-prefix=BACKSLASH -strict-whitespace %s // RUN: %clang --verbose -DBACKSLASH=\\ -S %s 2>&1 | FileCheck -check-prefix=BACKSLASH -strict-whitespace %s
// RUN: %clang --verbose -DDOLLAR=\$ -c %s 2>&1 | FileCheck -check-prefix=DOLLAR -strict-whitespace %s // RUN: %clang --verbose -DDOLLAR=\$ -S %s 2>&1 | FileCheck -check-prefix=DOLLAR -strict-whitespace %s
// SPACE: -cc1 {{.*}} -D "SPACE=a b" // SPACE: -cc1 {{.*}} -D "SPACE=a b"
// QUOTES: -cc1 {{.*}} -D "QUOTES=\"\"" // QUOTES: -cc1 {{.*}} -D "QUOTES=\"\""
// BACKSLASH: -cc1 {{.*}} -D "BACKSLASH=\\" // BACKSLASH: -cc1 {{.*}} -D "BACKSLASH=\\"
// DOLLAR: -cc1 {{.*}} -D "DOLLAR=\$" // DOLLAR: -cc1 {{.*}} -D "DOLLAR=\$"