This is an archive of the discontinued LLVM Phabricator instance.

gn build: Use rebase_path on filename args to libcxx/utils/gen_link_script.py
ClosedPublic

Authored by hans on Jul 30 2019, 6:56 AM.

Details

Summary

Otherwise it fails for me like this:

$ ninja -j800
[1/5] ACTION //libcxx/src:cxx_linker_script(//llvm/utils/gn/build/toolchain:stage2_unix)
FAILED: lib/libc++.so 
python ../libcxx/utils/gen_link_script.py --input //build.gn/lib/libc++.so.0 --output //build.gn/lib/libc++.so c++abi unwind
GENERATING SCRIPT: 'INPUT(libc++.so.0 -lc++abi -lunwind)' as file //build.gn/lib/libc++.so
Traceback (most recent call last):
  File "../libcxx/utils/gen_link_script.py", line 57, in <module>
    sys.exit(main())
  File "../libcxx/utils/gen_link_script.py", line 50, in main
    with open(args.output, 'w') as f:
IOError: [Errno 2] No such file or directory: '//build.gn/lib/libc++.so'
ninja: build stopped: subcommand failed.

Diff Detail

Event Timeline

hans created this revision.Jul 30 2019, 6:56 AM
Herald added a project: Restricted Project. · View Herald Transcript
thakis accepted this revision.Jul 30 2019, 7:02 AM

lgtm

This revision is now accepted and ready to land.Jul 30 2019, 7:02 AM
This revision was automatically updated to reflect the committed changes.