Page MenuHomePhabricator

[docs] Add note about git version to git-llvm section
AbandonedPublic

Authored by sgraenitz on Jul 30 2019, 3:09 AM.

Details

Summary

From the mailing list. Git is necessary in one way or other. Version 2.9.3 is 3 years old now and may be a suitable minimum version:
https://git-scm.com/docs/git-remote/2.9.3
What do you think?

Event Timeline

sgraenitz created this revision.Jul 30 2019, 3:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2019, 3:09 AM
sgraenitz edited the summary of this revision. (Show Details)Jul 30 2019, 3:10 AM
rovka added a subscriber: rovka.Jul 30 2019, 4:32 AM

Some people might be interested just in compiling LLVM (e.g. fetching some release sources from releases.llvm.org and building them). We should probably keep the package list here focused on that. If we want to add git at all, we should probably mention it somewhere else. I'm not sure where that would be - I suppose somewhere where it makes sense to worry about the minimum version, e.g. where the git-llvm script is concerned. Do we have any other reason to bind ourselves to a certain minimum version of git?

I also notice that the current list mentions make instead of cmake + some build tool of choice. Seems to me we're not very good at keeping our requirements up to date, so maybe we shouldn't add more of them if not super relevant?

See the llvm-commits replies to r365917; at least one code owner is stuck with 1.8.3.

But this should be discussed on llvm-dev first so more people will notice it.

I don't really want to promise any particular version, because nobody is really checking that particular versions of git work -- the way our scripts continue work with old versions is when developers use them and report a problem. The only real requirement here is "whatever the oldest version someone's actually used recently".

Couple that with git not being a core requirement, I'd rather just say nothing, unless we had an affirmative intent to /not/ support some particular version.

sgraenitz updated this revision to Diff 212336.Jul 30 2019, 7:26 AM

Move git version comment into a footnote in git-llvm section

Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2019, 7:26 AM
sgraenitz updated this revision to Diff 212338.Jul 30 2019, 7:29 AM

Remove lldb documentation updates I just added accidentally

Harbormaster completed remote builds in B35804: Diff 212338.
sgraenitz updated this revision to Diff 212340.Jul 30 2019, 7:33 AM

Undo Compiling -> Working with

If we want to add git at all, we should probably mention it somewhere else. I'm not sure where that would be - I suppose somewhere where it makes sense to worry about the minimum version, e.g. where the git-llvm script is concerned.

Agree, changed that.

See the llvm-commits replies to r365917; at least one code owner is stuck with 1.8.3.

This is here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20190715/674326.html

The only real requirement here is "whatever the oldest version someone's actually used recently". Couple that with git not being a core requirement, I'd rather just say nothing, unless we had an affirmative intent to /not/ support some particular version.

It may complicate the git-llvm script, but it seems to work so far, so fair enough.

sgraenitz retitled this revision from [docs] Add git to list of Software requirements to [docs] Add note about git version to git-llvm section.Jul 30 2019, 7:40 AM
sgraenitz abandoned this revision.Aug 2 2019, 9:56 AM