Page MenuHomePhabricator

Remove cache for macro arg stringization
ClosedPublic

Authored by rnk on Jul 29 2019, 6:30 PM.

Details

Summary

The cache recorded the wrong expansion location for all but the first
stringization. It seems uncommon to stringize the same macro argument
multiple times, so this cache doesn't seem that important.

Fixes PR39942

Diff Detail

Repository
rL LLVM

Event Timeline

rnk created this revision.Jul 29 2019, 6:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2019, 6:30 PM
vsk accepted this revision.Jul 30 2019, 10:40 AM

Thanks, lgtm.

This revision is now accepted and ready to land.Jul 30 2019, 10:40 AM
rnk added a comment.Jul 30 2019, 10:58 AM

Thanks for looking into it as well, I would not have seen the issue without reviewing the test case again. :)

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2019, 10:59 AM