This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][MC][GFX10] Enabled null with 64-bit operands
ClosedPublic

Authored by dp on Jul 24 2019, 10:43 AM.

Reviewers

arsenm
artem.tamazov

Summary

lol, you've already made null reads free from the constant bus POV ;)
LGTM

This revision is now accepted and ready to land.Aug 30 2019, 7:52 AM

Integrated in 370660

Path

Size

lib/

Target/

AMDGPU/

AsmParser/

2 lines

test/

MC/

AMDGPU/

8 lines

Show First 20 Lines • Show All 1,843 Lines • ▼ Show 20 Lines	static bool isInlineValue(unsigned Reg) {
case AMDGPU::SRC_PRIVATE_BASE:		case AMDGPU::SRC_PRIVATE_BASE:
case AMDGPU::SRC_PRIVATE_LIMIT:		case AMDGPU::SRC_PRIVATE_LIMIT:
case AMDGPU::SRC_POPS_EXITING_WAVE_ID:		case AMDGPU::SRC_POPS_EXITING_WAVE_ID:
return true;		return true;
case AMDGPU::SRC_VCCZ:		case AMDGPU::SRC_VCCZ:
case AMDGPU::SRC_EXECZ:		case AMDGPU::SRC_EXECZ:
case AMDGPU::SRC_SCC:		case AMDGPU::SRC_SCC:
return true;		return true;
		case AMDGPU::SGPR_NULL:
		return true;
default:		default:
return false;		return false;
}		}
}		}

bool AMDGPUOperand::isInlineValue() const {		bool AMDGPUOperand::isInlineValue() const {
return isRegKind() && ::isInlineValue(getReg());		return isRegKind() && ::isInlineValue(getReg());
}		}
▲ Show 20 Lines • Show All 5,021 Lines • Show Last 20 Lines

	Show First 20 Lines • Show All 110 Lines • ▼ Show 20 Lines

	flat_load_dwordx4 [v[8/2+4],v9,v[10],v[11/2+6]], v[2:3]			flat_load_dwordx4 [v[8/2+4],v9,v[10],v[11/2+6]], v[2:3]
	// VI: flat_load_dwordx4 v[8:11], v[2:3] ; encoding: [0x00,0x00,0x5c,0xdc,0x02,0x00,0x00,0x08]			// VI: flat_load_dwordx4 v[8:11], v[2:3] ; encoding: [0x00,0x00,0x5c,0xdc,0x02,0x00,0x00,0x08]

	v_mul_f32 v0, null, v2			v_mul_f32 v0, null, v2
	// NOSICIVI: error:			// NOSICIVI: error:
	// GFX10: v_mul_f32_e32 v0, null, v2 ; encoding: [0x7d,0x04,0x00,0x10]			// GFX10: v_mul_f32_e32 v0, null, v2 ; encoding: [0x7d,0x04,0x00,0x10]

				v_mul_f64 v[0:1], null, null
				// NOSICIVI: error:
				// GFX10: v_mul_f64 v[0:1], null, null ; encoding: [0x00,0x00,0x65,0xd5,0x7d,0xfa,0x00,0x00]

	s_add_u32 null, null, null			s_add_u32 null, null, null
	// NOSICIVI: error:			// NOSICIVI: error:
	// GFX10: s_add_u32 null, null, null ; encoding: [0x7d,0x7d,0x7d,0x80]			// GFX10: s_add_u32 null, null, null ; encoding: [0x7d,0x7d,0x7d,0x80]

				s_not_b64 s[2:3], null
				// NOSICIVI: error:
				// GFX10: s_not_b64 s[2:3], null ; encoding: [0x7d,0x08,0x82,0xbe]