This is an archive of the discontinued LLVM Phabricator instance.

Differential D65160

[libFuzzer] Fix __sanitizer_print_memory_profile return type in ExtFunctions.def
ClosedPublic

Authored by Dor1s on Jul 23 2019, 11:24 AM.

Details

Reviewers
kcc
Dor1s
Commits
rG374398afb784: [libFuzzer] Fix __sanitizer_print_memory_profile return type in ExtFunctions.def
rL366834: [libFuzzer] Fix __sanitizer_print_memory_profile return type in ExtFunctions.def
rCRT366834: [libFuzzer] Fix __sanitizer_print_memory_profile return type in ExtFunctions.def
Summary

Looks like a typo, as that function actually returns void and is used
as such in libFuzzer code as well.

Diff Detail

Event Timeline

Dor1s created this revision.Jul 23 2019, 11:24 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 23 2019, 11:24 AM
Herald added subscribers: llvm-commits, Restricted Project, delcypher. · View Herald Transcript
Dor1s accepted this revision.Jul 23 2019, 11:25 AM

TBR as it seems to be a trivial fix. Tests do not break locally. Will revert if anything goes wrong :)

This revision is now accepted and ready to land.Jul 23 2019, 11:25 AM
Harbormaster completed remote builds in B35529: Diff 211338.Jul 23 2019, 11:28 AM
Closed by commit rL366834: [libFuzzer] Fix __sanitizer_print_memory_profile return type in ExtFunctions.def (authored by Dor1s). · Explain WhyJul 23 2019, 11:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
fuzzer/
2 lines

Diff 211338

lib/fuzzer/FuzzerExtFunctions.def

Show All 28 Lines
EXT_FUNC(__lsan_disable, void, (), false); EXT_FUNC(__lsan_disable, void, (), false);
EXT_FUNC(__lsan_do_recoverable_leak_check, int, (), false); EXT_FUNC(__lsan_do_recoverable_leak_check, int, (), false);
EXT_FUNC(__sanitizer_acquire_crash_state, int, (), true); EXT_FUNC(__sanitizer_acquire_crash_state, int, (), true);
EXT_FUNC(__sanitizer_install_malloc_and_free_hooks, int, EXT_FUNC(__sanitizer_install_malloc_and_free_hooks, int,
(void (*malloc_hook)(const volatile void *, size_t), (void (*malloc_hook)(const volatile void *, size_t),
void (*free_hook)(const volatile void *)), void (*free_hook)(const volatile void *)),
false); false);
EXT_FUNC(__sanitizer_purge_allocator, void, (), false); EXT_FUNC(__sanitizer_purge_allocator, void, (), false);
EXT_FUNC(__sanitizer_print_memory_profile, int, (size_t, size_t), false); EXT_FUNC(__sanitizer_print_memory_profile, void, (size_t, size_t), false);
EXT_FUNC(__sanitizer_print_stack_trace, void, (), true); EXT_FUNC(__sanitizer_print_stack_trace, void, (), true);
EXT_FUNC(__sanitizer_symbolize_pc, void, EXT_FUNC(__sanitizer_symbolize_pc, void,
(void *, const char *fmt, char *out_buf, size_t out_buf_size), false); (void *, const char *fmt, char *out_buf, size_t out_buf_size), false);
EXT_FUNC(__sanitizer_get_module_and_offset_for_pc, int, EXT_FUNC(__sanitizer_get_module_and_offset_for_pc, int,
(void *pc, char *module_path, (void *pc, char *module_path,
size_t module_path_len,void **pc_offset), false); size_t module_path_len,void **pc_offset), false);
EXT_FUNC(__sanitizer_set_death_callback, void, (void (*)(void)), true); EXT_FUNC(__sanitizer_set_death_callback, void, (void (*)(void)), true);
EXT_FUNC(__sanitizer_set_report_fd, void, (void*), false); EXT_FUNC(__sanitizer_set_report_fd, void, (void*), false);
EXT_FUNC(__msan_scoped_disable_interceptor_checks, void, (), false); EXT_FUNC(__msan_scoped_disable_interceptor_checks, void, (), false);
EXT_FUNC(__msan_scoped_enable_interceptor_checks, void, (), false); EXT_FUNC(__msan_scoped_enable_interceptor_checks, void, (), false);
EXT_FUNC(__msan_unpoison, void, (const volatile void *, size_t size), false); EXT_FUNC(__msan_unpoison, void, (const volatile void *, size_t size), false);
EXT_FUNC(__msan_unpoison_param, void, (size_t n), false); EXT_FUNC(__msan_unpoison_param, void, (size_t n), false);