This is an archive of the discontinued LLVM Phabricator instance.

Differential D64965

[cmake] Fix typo where a varible was checked for Apple instead of Darwin
ClosedPublic

Authored by lanza on Jul 18 2019, 5:17 PM.

Details

Reviewers
JDevlieghere
Commits
rG3d9955c869f4: [cmake] Fix typo where a varible was checked for Apple instead of Darwin
rL366515: [cmake] Fix typo where a varible was checked for Apple instead of Darwin

Diff Detail

Event Timeline

lanza created this revision.Jul 18 2019, 5:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2019, 5:17 PM
Herald added subscribers: llvm-commits, mgorny. · View Herald Transcript
lanza added a reviewer: JDevlieghere.Jul 18 2019, 5:18 PM
Harbormaster completed remote builds in B35321: Diff 210709.Jul 18 2019, 5:19 PM
JDevlieghere accepted this revision.Jul 18 2019, 5:20 PM
This revision is now accepted and ready to land.Jul 18 2019, 5:20 PM
JDevlieghere added inline comments.Jul 18 2019, 5:21 PM
cmake/modules/AddLLVM.cmake
1685

Actually, should this be quoted?

Closed by commit rL366515: [cmake] Fix typo where a varible was checked for Apple instead of Darwin (authored by lanza). · Explain WhyJul 18 2019, 5:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cmake/
modules/
2 lines

Diff 210709

cmake/modules/AddLLVM.cmake

Show First 20 Lines • Show All 1,676 Lines • ▼ Show 20 Lines if(CMAKE_GENERATOR STREQUAL "Xcode")
set_target_properties(${name} PROPERTIES set_target_properties(${name} PROPERTIES
XCODE_ATTRIBUTE_CODE_SIGN_IDENTITY ${LLVM_CODESIGNING_IDENTITY} XCODE_ATTRIBUTE_CODE_SIGN_IDENTITY ${LLVM_CODESIGNING_IDENTITY}
) )
if(DEFINED ARG_ENTITLEMENTS) if(DEFINED ARG_ENTITLEMENTS)
set_target_properties(${name} PROPERTIES set_target_properties(${name} PROPERTIES
XCODE_ATTRIBUTE_CODE_SIGN_ENTITLEMENTS ${ARG_ENTITLEMENTS} XCODE_ATTRIBUTE_CODE_SIGN_ENTITLEMENTS ${ARG_ENTITLEMENTS}
) )
endif() endif()
elseif(APPLE AND CMAKE_HOST_SYSTEM_NAME MATCHES APPLE) elseif(APPLE AND CMAKE_HOST_SYSTEM_NAME MATCHES Darwin)
JDevlieghereUnsubmitted
Not Done
ReplyInline Actions

Actually, should this be quoted?

JDevlieghere: Actually, should this be quoted?
if(NOT CMAKE_CODESIGN) if(NOT CMAKE_CODESIGN)
set(CMAKE_CODESIGN xcrun codesign) set(CMAKE_CODESIGN xcrun codesign)
endif() endif()
if(NOT CMAKE_CODESIGN_ALLOCATE) if(NOT CMAKE_CODESIGN_ALLOCATE)
execute_process( execute_process(
COMMAND xcrun -f codesign_allocate COMMAND xcrun -f codesign_allocate
OUTPUT_STRIP_TRAILING_WHITESPACE OUTPUT_STRIP_TRAILING_WHITESPACE
OUTPUT_VARIABLE CMAKE_CODESIGN_ALLOCATE OUTPUT_VARIABLE CMAKE_CODESIGN_ALLOCATE
▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines