Page MenuHomePhabricator

[WebAssembly] Use passive segments by default when memory is shared
ClosedPublic

Authored by tlively on Jul 18 2019, 2:09 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

tlively created this revision.Jul 18 2019, 2:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2019, 2:09 PM
quantum added inline comments.Jul 18 2019, 2:23 PM
lld/wasm/Driver.cpp
324–326 ↗(On Diff #210668)

This logic seems a bit hard to understand...

Would this work?

args.hasFlag(OPT_passive_segments, OPT_active_segments, config->sharedMemory);
tlively updated this revision to Diff 210680.Jul 18 2019, 2:37 PM
tlively marked 2 inline comments as done.
  • Simplify flags logic
lld/wasm/Driver.cpp
324–326 ↗(On Diff #210668)

Nice! I thought that bool was for something else entirely.

quantum accepted this revision.Jul 18 2019, 2:42 PM
This revision is now accepted and ready to land.Jul 18 2019, 2:42 PM
This revision was automatically updated to reflect the committed changes.