This is an archive of the discontinued LLVM Phabricator instance.

Differential D64890

hwasan: Use C++ driver for cfi.cc test.
ClosedPublic

Authored by pcc on Jul 17 2019, 3:25 PM.

Details

Reviewers
eugenis
Commits
rG749f556bbd14: hwasan: Use C++ driver for cfi.cc test.
rCRT366389: hwasan: Use C++ driver for cfi.cc test.
rL366389: hwasan: Use C++ driver for cfi.cc test.
Summary

It turns out that this test was only passing by accident. It was relying on
the optimizer to remove the only reference to A's vtable by realizing that
the CFI check will always fail. The vtable contains a reference to RTTI in
libc++, which will be unresolved because the C driver won't link against it.

This was found by my prototype implementation of HWASAN for globals, which
happens to end up preserving the reference.

Diff Detail

Event Timeline

pcc created this revision.Jul 17 2019, 3:25 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 17 2019, 3:25 PM
Herald added subscribers: Restricted Project, kubamracek. · View Herald Transcript
Harbormaster completed remote builds in B35203: Diff 210438.Jul 17 2019, 3:25 PM
eugenis accepted this revision.Jul 17 2019, 4:29 PM

LGTM

This revision is now accepted and ready to land.Jul 17 2019, 4:29 PM
Closed by commit rL366389: hwasan: Use C++ driver for cfi.cc test. (authored by pcc). · Explain WhyJul 17 2019, 4:39 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: delcypher. · View Herald TranscriptJul 17 2019, 4:39 PM

Revision Contents

PathSize
compiler-rt/
test/
hwasan/
TestCases/
2 lines

Diff 210438

compiler-rt/test/hwasan/TestCases/cfi.cc

// RUN: %clang_hwasan -fsanitize=cfi -fno-sanitize-trap=cfi -flto -fvisibility=hidden -fuse-ld=lld %s -o %t // RUN: %clangxx_hwasan -fsanitize=cfi -fno-sanitize-trap=cfi -flto -fvisibility=hidden -fuse-ld=lld %s -o %t
// RUN: not %run %t 2>&1 | FileCheck %s // RUN: not %run %t 2>&1 | FileCheck %s
// REQUIRES: android // REQUIRES: android
// Smoke test for CFI + HWASAN. // Smoke test for CFI + HWASAN.
struct A { struct A {
virtual void f(); virtual void f();
Show All 9 Lines