Page MenuHomePhabricator

[OpenCL] Update comments/diagnostics to refer to C++ for OpenCL mode
ClosedPublic

Authored by Anastasia on Jul 17 2019, 6:31 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

Anastasia created this revision.Jul 17 2019, 6:31 AM

It would be good if you could provide some motivation for this change in the description of this review.

include/clang/Basic/DiagnosticParseKinds.td
1157 ↗(On Diff #210313)

Please align on either "C++ for OpenCL" or "C++ for OpenCL mode" (in DiagnosticCommonKinds.td).

lib/Sema/SemaDecl.cpp
6429 ↗(On Diff #210313)

*the* thread_local storage qualifier.

Anastasia edited the summary of this revision. (Show Details)
  • Updated comments
  • Added motivation
svenvh accepted this revision.Jul 18 2019, 1:41 AM

LGTM

This revision is now accepted and ready to land.Jul 18 2019, 1:41 AM
neil.hickey added inline comments.Jul 18 2019, 1:42 AM
lib/Frontend/InitPreprocessor.cpp
414 ↗(On Diff #210381)

Shouldn't this be C++ for OpenCL version as in other places you use it as a noun

lib/Parse/ParseDecl.cpp
3562 ↗(On Diff #210381)

need a comma between qualifier and to to remove ambiguity

Anastasia marked 2 inline comments as done.Jul 18 2019, 2:24 AM
Anastasia added inline comments.
lib/Frontend/InitPreprocessor.cpp
414 ↗(On Diff #210381)

I think it refers to C++ version... but can probably be both.

lib/Parse/ParseDecl.cpp
3562 ↗(On Diff #210381)

Thanks! I will change in the final commit.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2019, 3:03 AM