Page MenuHomePhabricator

neil.hickey (Neil Hickey)
Tech Lead, OpenCL Compiler GPU Division Arm

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2015, 1:00 AM (230 w, 2 d)

Recent Activity

Jul 18 2019

neil.hickey added inline comments to D64867: [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL mode.
Jul 18 2019, 1:42 AM · Restricted Project

Jul 16 2019

neil.hickey committed rG8ece3b671994: [OpenCL] Fixing sampler initialisations for C++ mode. (authored by neil.hickey).
[OpenCL] Fixing sampler initialisations for C++ mode.
Jul 16 2019, 7:58 AM
neil.hickey committed rL366212: [OpenCL] Fixing sampler initialisations for C++ mode..
[OpenCL] Fixing sampler initialisations for C++ mode.
Jul 16 2019, 7:57 AM
neil.hickey closed D64791: [OpenCL] Fix sampler initialization for C++ mode.
Jul 16 2019, 7:57 AM · Restricted Project
neil.hickey created D64791: [OpenCL] Fix sampler initialization for C++ mode.
Jul 16 2019, 4:30 AM · Restricted Project

Jul 9 2019

neil.hickey added inline comments to D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode.
Jul 9 2019, 9:39 AM · Restricted Project

Mar 11 2019

neil.hickey accepted D59219: [PR41007][OpenCL] Allow printf and toolchain reserved variadic functions in C++.

LGTM!

Mar 11 2019, 10:20 AM · Restricted Project

Dec 14 2016

neil.hickey committed rL289650: Fixing cast condition for removing casts from builtin FPClassification..
Fixing cast condition for removing casts from builtin FPClassification.
Dec 14 2016, 5:29 AM

Dec 13 2016

neil.hickey committed rL289552: Fixing build failure by adding triple option to new test condition..
Fixing build failure by adding triple option to new test condition.
Dec 13 2016, 9:15 AM
neil.hickey committed rL289544: Improve handling of floating point literals in OpenCL to only use double….
Improve handling of floating point literals in OpenCL to only use double…
Dec 13 2016, 8:33 AM
neil.hickey closed D24235: [OpenCL] Improve floating point literal handling by committing rL289544: Improve handling of floating point literals in OpenCL to only use double….
Dec 13 2016, 8:33 AM

Nov 15 2016

neil.hickey updated the diff for D24235: [OpenCL] Improve floating point literal handling.

Fixing indentation and improving comments.

Nov 15 2016, 3:47 AM
neil.hickey reopened D24235: [OpenCL] Improve floating point literal handling.
Nov 15 2016, 2:44 AM
neil.hickey updated the diff for D24235: [OpenCL] Improve floating point literal handling.

Fixes to tests and removal of incorrect check to stop float to float casts if types match. This was still needed as it was an lvalue to rvalue cast. Added extra code in SemaChecking to allow a float to float cast to appear and be handled.

Nov 15 2016, 2:44 AM

Nov 14 2016

neil.hickey committed rL286815: Improve handling of floating point literals in OpenCL to only use double….
Improve handling of floating point literals in OpenCL to only use double…
Nov 14 2016, 3:25 AM
neil.hickey closed D24235: [OpenCL] Improve floating point literal handling by committing rL286815: Improve handling of floating point literals in OpenCL to only use double….
Nov 14 2016, 3:25 AM

Nov 11 2016

neil.hickey updated the diff for D24235: [OpenCL] Improve floating point literal handling.

Improving now confusing comment.

Nov 11 2016, 1:44 AM

Nov 10 2016

neil.hickey added a reviewer for D24235: [OpenCL] Improve floating point literal handling: svenvh.
Nov 10 2016, 2:53 AM

Nov 9 2016

neil.hickey updated the diff for D24235: [OpenCL] Improve floating point literal handling.

Moving location of no-diagnostics statement to beginning of file

Nov 9 2016, 2:03 AM

Nov 1 2016

neil.hickey updated the diff for D24235: [OpenCL] Improve floating point literal handling.

Sorry for the delay. It looks like the code to handle extensions was changed since Neil Henning added the check against opencl 1.2. Perhaps the best approach is just to remove the check.

Nov 1 2016, 9:58 AM

Sep 20 2016

neil.hickey added inline comments to D24235: [OpenCL] Improve floating point literal handling.
Sep 20 2016, 2:18 AM

Sep 19 2016

neil.hickey added a reviewer for D24235: [OpenCL] Improve floating point literal handling: joey.
Sep 19 2016, 9:47 AM
neil.hickey reopened D24235: [OpenCL] Improve floating point literal handling.
Sep 19 2016, 9:05 AM
neil.hickey updated the diff for D24235: [OpenCL] Improve floating point literal handling.

There was a bug whereby an implicitcast was being applied from float to float, this caused issues later on in builin processing which caused an assertion. This changed patch removes the duplicate, superfluous, cast.

Sep 19 2016, 9:05 AM
neil.hickey committed rL281899: Reverting r281714 due to causing an assert when calling builtins that expect….
Reverting r281714 due to causing an assert when calling builtins that expect…
Sep 19 2016, 4:51 AM

Sep 16 2016

neil.hickey added a comment to D24235: [OpenCL] Improve floating point literal handling.

committed @ 281714

Sep 16 2016, 3:47 AM
neil.hickey closed D24235: [OpenCL] Improve floating point literal handling.

Commit merged to trunk

Sep 16 2016, 3:45 AM
neil.hickey committed rL281714: Improve handling of floating point literals in OpenCL to only use double….
Improve handling of floating point literals in OpenCL to only use double…
Sep 16 2016, 3:23 AM
neil.hickey committed rL281711: Testing commit rights. Removing trailing white space from test file..
Testing commit rights. Removing trailing white space from test file.
Sep 16 2016, 2:47 AM

Sep 9 2016

neil.hickey added inline comments to D24235: [OpenCL] Improve floating point literal handling.
Sep 9 2016, 3:00 AM
neil.hickey updated the diff for D24235: [OpenCL] Improve floating point literal handling.

Modifying formating to match LLVM style. Adding new test to confirm that the vararg for printf is cast up to a double is allowable.

Sep 9 2016, 2:59 AM

Sep 7 2016

neil.hickey updated the diff for D24235: [OpenCL] Improve floating point literal handling.

Added a CodeGen test as well as fixed an issue with vararg type promotion

Sep 7 2016, 6:50 AM

Sep 5 2016

neil.hickey retitled D24235: [OpenCL] Improve floating point literal handling from to [OpenCL] Improve double literal handling.
Sep 5 2016, 7:53 AM

Dec 21 2015

neil.hickey retitled D15691: [OpenCL] Improving OpenCL function pointer error checking to catch lone function designator from to [OpenCL] Improving OpenCL function pointer error checking to catch lone function designator.
Dec 21 2015, 8:16 AM

Oct 2 2015

neil.hickey updated the diff for D13349: [OpenCL] Casting boolean to an integer vector in OpenCL should set all bits if boolean is true.

Fixing formatting problems.

Oct 2 2015, 5:27 AM

Oct 1 2015

neil.hickey retitled D13280: [OpenCL] Adding reserved operator logical xor for OpenCL from Adding reserved operator logical xor for OpenCL to [OpenCL] Adding reserved operator logical xor for OpenCL.
Oct 1 2015, 9:00 AM
neil.hickey retitled D13349: [OpenCL] Casting boolean to an integer vector in OpenCL should set all bits if boolean is true from Casting boolean to an integer vector in OpenCL should set all bits if boolean is true to [OpenCL] Casting boolean to an integer vector in OpenCL should set all bits if boolean is true.
Oct 1 2015, 8:56 AM
neil.hickey retitled D13349: [OpenCL] Casting boolean to an integer vector in OpenCL should set all bits if boolean is true from to Casting boolean to an integer vector in OpenCL should set all bits if boolean is true.
Oct 1 2015, 8:29 AM

Sep 30 2015

neil.hickey retitled D13280: [OpenCL] Adding reserved operator logical xor for OpenCL from to Adding reserved operator logical xor for OpenCL.
Sep 30 2015, 1:36 AM