This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Make log for ClangModulesDeclVendor's compiler flag less verbose
ClosedPublic

Authored by teemperor on Jul 17 2019, 3:59 AM.

Details

Summary

Currently the ClangModulesDeclVendor is spamming the expression log with the compiler flags it is using, which creates a log that looks like this:

clang


 -fmodules


 -fimplicit-module-maps

This patch removes all these newlines and just prints the compiler flags in one line as you see in the command line:

clang -fmodules -fimplicit-module-maps [...]

Diff Detail

Event Timeline

teemperor created this revision.Jul 17 2019, 3:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2019, 3:59 AM
davide accepted this revision.Jul 17 2019, 8:31 AM
davide added a subscriber: davide.

This looks good. If it bothers you a lot (given you're probably one of the few users), you can do this only under verbose (although now that's a single line is very concise).

This revision is now accepted and ready to land.Jul 17 2019, 8:31 AM

Is it worth it to write a test that verifies the output? Otherwise LGTM.

I don't think it's worth adding a test for the logs.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2019, 9:55 AM