Page MenuHomePhabricator

Skip zero column for inline sites
ClosedPublic

Authored by wenlei on Jul 15 2019, 8:21 PM.

Details

Summary

D64033 added DW_AT_call_column for inline sites. However, that change wasn't aware of "-gno-column-info". To avoid adding column info when "-gno-column-info" is used, now DW_AT_call_column is only added when we have non-zero column (when "-gno-column-info" is used, column will be zero).

Test Plan:
ninja check

Diff Detail

Repository
rL LLVM

Event Timeline

wenlei created this revision.Jul 15 2019, 8:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2019, 8:21 PM

Test coverage? (you could add another inlined call to the test case you added for the feature - but just leave the inlined-at location with a zero column for that particular call - so you can still test both positive/negatiev in the one file)

wenlei updated this revision to Diff 210020.Jul 15 2019, 8:58 PM

Tweak test case to add coverage for zero-coloumn inline site

Test coverage? (you could add another inlined call to the test case you added for the feature - but just leave the inlined-at location with a zero column for that particular call - so you can still test both positive/negatiev in the one file)

Thanks! done.

dblaikie accepted this revision.Jul 15 2019, 9:13 PM
This revision is now accepted and ready to land.Jul 15 2019, 9:13 PM

@dblaikie, thanks for review. Could you help land this change? I don't have commit permission yet..

This revision was automatically updated to reflect the committed changes.