Page MenuHomePhabricator

[SWIG] Deprecate SWIG 1.x
ClosedPublic

Authored by JDevlieghere on Jul 15 2019, 5:52 PM.

Details

Summary

The last swig 1.x release dates from 2009, now 10 years ago. Recently I fixed an issue that prevented us from using swig 4 (rL364974), which apparently was not backward compatible with swig 1.x (rL365718). Rather that introducing the workaround for all the properties, I propose to deprecate this (really old) version.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Jul 15 2019, 5:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2019, 5:52 PM
Herald added a subscriber: mgorny. · View Herald Transcript
davide accepted this revision.Jul 15 2019, 5:58 PM
davide added a subscriber: davide.

LGTM. Thanks. I fear this might break some bots, but the best way to see if that's the case is trying.

This revision is now accepted and ready to land.Jul 15 2019, 5:58 PM

LGTM. Thanks. I fear this might break some bots, but the best way to see if that's the case is trying.

I've updated swig on GreenDragon, and the Windows bot is running 3.0. I'm not sure about the Debian bot, as it's incremental it doesn't print the version number. Regardless, I'll keep an eye on the bots of course.

labath added a subscriber: labath.Jul 16 2019, 4:35 AM

I've updated swig on GreenDragon, and the Windows bot is running 3.0. I'm not sure about the Debian bot, as it's incremental it doesn't print the version number. Regardless, I'll keep an eye on the bots of course.

You can see the environment the "debian" bot is running in on it's "buildslave" page http://lab.llvm.org:8014/buildslaves/lldb-x86_64-debian. The swig version it uses is 3.0.12. The information on that page is hand-populated, so there is a danger of it getting out of date, but it should be correct at the moment.

Also, lgtm. :)

Closed by commit rL366213: [SWIG] Deprecate SWIG 1.x (authored by JDevlieghere, committed by ). · Explain WhyJul 16 2019, 8:15 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 16 2019, 8:15 AM