Page MenuHomePhabricator

Slightly simplify MappedBlockStream::createIndexedStream() calls

Authored by thakis on Jul 12 2019, 7:06 AM.



All callers had a PDBFile object at hand, so call Pdb.createIndexedStream() instead, which pre-populates all the arguments (and returns nullptr for kInvalidStreamIndex).

Also change safelyCreateIndexedStream() to only take the string index, and update callers. Make the method public and call it in two places that manually did the bounds checking before.

No intended behavior change.

Diff Detail

Event Timeline

thakis created this revision.Jul 12 2019, 7:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2019, 7:06 AM
rnk accepted this revision.Jul 12 2019, 11:20 AM


This revision is now accepted and ready to land.Jul 12 2019, 11:20 AM
This revision was automatically updated to reflect the committed changes.