Page MenuHomePhabricator

Slightly simplify MappedBlockStream::createIndexedStream() calls
ClosedPublic

Authored by thakis on Fri, Jul 12, 7:06 AM.

Details

Summary

All callers had a PDBFile object at hand, so call Pdb.createIndexedStream() instead, which pre-populates all the arguments (and returns nullptr for kInvalidStreamIndex).

Also change safelyCreateIndexedStream() to only take the string index, and update callers. Make the method public and call it in two places that manually did the bounds checking before.

No intended behavior change.

Diff Detail

Repository
rL LLVM

Event Timeline

thakis created this revision.Fri, Jul 12, 7:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Jul 12, 7:06 AM
rnk accepted this revision.Fri, Jul 12, 11:20 AM

lgtm

This revision is now accepted and ready to land.Fri, Jul 12, 11:20 AM
This revision was automatically updated to reflect the committed changes.