This is an archive of the discontinued LLVM Phabricator instance.

[lldb][test_suite] Fix skipIfTargetAndroid decorator
ClosedPublic

Authored by kusmour on Jul 11 2019, 12:27 PM.

Details

Summary

Delete the duplicate func skipIfTargetAndroid
Fix the old one. It didn't work for missing an argument bugnumber, this somehow made the decorator failed

Diff Detail

Repository
rLLDB LLDB

Event Timeline

kusmour created this revision.Jul 11 2019, 12:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2019, 12:27 PM

Can you add more context to this diff? I can't see the code surrounding the changes. You can get the whole context with something like git show -U9999.

kusmour updated this revision to Diff 209325.Jul 11 2019, 1:57 PM
kusmour edited the summary of this revision. (Show Details)

add more context to diff

This revision is now accepted and ready to land.Jul 17 2019, 11:13 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2019, 5:41 PM