Page MenuHomePhabricator

[CGDebugInfo] Simplfiy EmitFunctionDecl parameters, NFC
Changes PlannedPublic

Authored by vsk on Wed, Jul 10, 3:44 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

vsk created this revision.Wed, Jul 10, 3:44 PM
djtodoro accepted this revision.Thu, Jul 11, 3:24 AM
djtodoro added a subscriber: debug-info.

LGTM! Thanks @vsk!

This revision is now accepted and ready to land.Thu, Jul 11, 3:26 AM

Not a huge fan of boolean parameters like this, perhaps factor out the context as well into the caller and then we don't need it at all? Something else?

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptThu, Jul 11, 12:11 PM
vsk reopened this revision.Thu, Jul 11, 12:28 PM

Sorry about that, reopening per Eric's comment.

This revision is now accepted and ready to land.Thu, Jul 11, 12:28 PM
vsk planned changes to this revision.Thu, Jul 11, 12:28 PM