Page MenuHomePhabricator

[CGDebugInfo] Simplfiy EmitFunctionDecl parameters, NFC
Changes PlannedPublic

Authored by vsk on Jul 10 2019, 3:44 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

vsk created this revision.Jul 10 2019, 3:44 PM
djtodoro accepted this revision.Jul 11 2019, 3:24 AM
djtodoro added a subscriber: debug-info.

LGTM! Thanks @vsk!

This revision is now accepted and ready to land.Jul 11 2019, 3:26 AM

Not a huge fan of boolean parameters like this, perhaps factor out the context as well into the caller and then we don't need it at all? Something else?

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2019, 12:11 PM
vsk reopened this revision.Jul 11 2019, 12:28 PM

Sorry about that, reopening per Eric's comment.

This revision is now accepted and ready to land.Jul 11 2019, 12:28 PM
vsk planned changes to this revision.Jul 11 2019, 12:28 PM