This is an archive of the discontinued LLVM Phabricator instance.

Differential D64488

[Driver] Support -fsanitize=function on Solaris/x86
ClosedPublic

Authored by ro on Jul 10 2019, 6:59 AM.

Details

Reviewers
kcc
krytarowski
Commits
rGbb669c25ba57: [Driver] Support -fsanitize=function on Solaris/x86
rC367351: [Driver] Support -fsanitize=function on Solaris/x86
rL367351: [Driver] Support -fsanitize=function on Solaris/x86
Summary

UBSan-Standalone-x86_64 :: TestCases/TypeCheck/Function/function.cpp currently
FAILs on Solaris/x86_64:

clang-9: error: unsupported option '-fsanitize=function' for target 'x86_64-pc-solaris2.11'

AFAICS, there's nothing more to do then enable that sanitizer in the driver (for x86 only),
which is what this patch does, together with updating another testcase.

Tested on x86_64-pc-solaris2.11. Ok for trunk?

Diff Detail

Repository
rC Clang

Event Timeline

ro created this revision.Jul 10 2019, 6:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2019, 6:59 AM
Herald added a subscriber: fedor.sergeev. · View Herald Transcript
ro added a reviewer: krytarowski.Jul 16 2019, 1:20 AM

Ping? It's been a week.

ro added a comment.Jul 23 2019, 4:19 AM

Ping^2? Two weeks now.

ro added a comment.Jul 29 2019, 6:23 AM

Ping^3? Three weeks and counting...

krytarowski added a comment.Jul 30 2019, 11:05 AM

Something is broken between reviews. and my mailbox as I am not receiving any e-mails so pinging does not make any effect... no LLVM admin replied to my questions on this to validate whether my mail was blacklisted or similar. I have decided to change server of my mailbox and workaround it.

test/Driver/fsanitize.c
721

Is twice x86_64 expected?

ro added a comment.Jul 30 2019, 11:14 AM
In D64488#1606716, @krytarowski wrote:

Something is broken between reviews. and my mailbox as I am not receiving any e-mails so pinging does not make any effect... no LLVM admin replied to my questions on this to validate whether my mail was blacklisted or similar. I have decided to change server of my mailbox and workaround it.

Maybe this is related to other reviews.llvm.org issues during the weekend where you couldn't update reviews with strange table full
errors?

test/Driver/fsanitize.c
721

No, one of those should be i386. Will fix.

ro updated this revision to Diff 212393.Jul 30 2019, 12:19 PM

Test i386--solaris instead of x86_64--solaris twice.

Retested on x86_64-pc-solaris2.11.

krytarowski added a comment.Jul 30 2019, 12:56 PM
In D64488#1606758, @ro wrote:
In D64488#1606716, @krytarowski wrote:

Something is broken between reviews. and my mailbox as I am not receiving any e-mails so pinging does not make any effect... no LLVM admin replied to my questions on this to validate whether my mail was blacklisted or similar. I have decided to change server of my mailbox and workaround it.

Maybe this is related to other reviews.llvm.org issues during the weekend where you couldn't update reviews with strange table full
errors?

I don't know. It lasts for a month or so. I wouldn't have noted this review without checking the phabricator page.

krytarowski accepted this revision.Jul 30 2019, 12:58 PM
This revision is now accepted and ready to land.Jul 30 2019, 12:58 PM
Closed by commit rL367351: [Driver] Support -fsanitize=function on Solaris/x86 (authored by ro). · Explain WhyJul 30 2019, 1:07 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2019, 1:07 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
lib/
Driver/
ToolChains/
3 lines
test/
Driver/
3 lines

Diff 208947

lib/Driver/ToolChains/Solaris.cpp

Show First 20 Lines • Show All 175 Lines • ▼ Show 20 LinesSolaris::Solaris(const Driver &D, const llvm::Triple &Triple,
if (StringRef(D.Dir).startswith(D.SysRoot)) if (StringRef(D.Dir).startswith(D.SysRoot))
addPathIfExists(D, D.Dir + "/../lib", Paths); addPathIfExists(D, D.Dir + "/../lib", Paths);
addPathIfExists(D, D.SysRoot + "/usr/lib" + LibSuffix, Paths); addPathIfExists(D, D.SysRoot + "/usr/lib" + LibSuffix, Paths);
} }
SanitizerMask Solaris::getSupportedSanitizers() const { SanitizerMask Solaris::getSupportedSanitizers() const {
const bool IsX86 = getTriple().getArch() == llvm::Triple::x86; const bool IsX86 = getTriple().getArch() == llvm::Triple::x86;
const bool IsX86_64 = getTriple().getArch() == llvm::Triple::x86_64;
const bool IsSparc = getTriple().getArch() == llvm::Triple::sparc; const bool IsSparc = getTriple().getArch() == llvm::Triple::sparc;
SanitizerMask Res = ToolChain::getSupportedSanitizers(); SanitizerMask Res = ToolChain::getSupportedSanitizers();
// FIXME: Omit X86_64 and SPARCv9 until 64-bit support is figured out. // FIXME: Omit X86_64 and SPARCv9 until 64-bit support is figured out.
if (IsX86 || IsSparc) { if (IsX86 || IsSparc) {
Res |= SanitizerKind::Address; Res |= SanitizerKind::Address;
Res |= SanitizerKind::PointerCompare; Res |= SanitizerKind::PointerCompare;
Res |= SanitizerKind::PointerSubtract; Res |= SanitizerKind::PointerSubtract;
} }
if (IsX86 || IsX86_64)
Res |= SanitizerKind::Function;
Res |= SanitizerKind::Vptr; Res |= SanitizerKind::Vptr;
return Res; return Res;
} }
Tool *Solaris::buildAssembler() const { Tool *Solaris::buildAssembler() const {
return new tools::solaris::Assembler(*this); return new tools::solaris::Assembler(*this);
} }
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines

test/Driver/fsanitize.c

Show First 20 Lines • Show All 711 Lines • ▼ Show 20 Lines
// RUN: %clang -target i386--netbsd -fsanitize=undefined %s -### 2>&1 | FileCheck %s -check-prefix=UNDEFINED-NETBSD // RUN: %clang -target i386--netbsd -fsanitize=undefined %s -### 2>&1 | FileCheck %s -check-prefix=UNDEFINED-NETBSD
// RUN: %clang -target x86_64--netbsd -fsanitize=undefined %s -### 2>&1 | FileCheck %s -check-prefix=UNDEFINED-NETBSD // RUN: %clang -target x86_64--netbsd -fsanitize=undefined %s -### 2>&1 | FileCheck %s -check-prefix=UNDEFINED-NETBSD
// UNDEFINED-NETBSD: "-fsanitize={{.*}} // UNDEFINED-NETBSD: "-fsanitize={{.*}}
// RUN: %clang -target i386--netbsd -fsanitize=scudo %s -### 2>&1 | FileCheck %s -check-prefix=SCUDO-NETBSD // RUN: %clang -target i386--netbsd -fsanitize=scudo %s -### 2>&1 | FileCheck %s -check-prefix=SCUDO-NETBSD
// RUN: %clang -target x86_64--netbsd -fsanitize=scudo %s -### 2>&1 | FileCheck %s -check-prefix=SCUDO-NETBSD // RUN: %clang -target x86_64--netbsd -fsanitize=scudo %s -### 2>&1 | FileCheck %s -check-prefix=SCUDO-NETBSD
// SCUDO-NETBSD: "-fsanitize=scudo" // SCUDO-NETBSD: "-fsanitize=scudo"
// RUN: %clang -target x86_64--solaris -fsanitize=function %s -### 2>&1 | FileCheck %s -check-prefix=FUNCTION-SOLARIS
// RUN: %clang -target x86_64--solaris -fsanitize=function %s -### 2>&1 | FileCheck %s -check-prefix=FUNCTION-SOLARIS
krytarowskiUnsubmitted
Not Done
ReplyInline Actions

Is twice x86_64 expected?

krytarowski: Is twice x86_64 expected?
roAuthorUnsubmitted
Not Done
ReplyInline Actions

No, one of those should be i386. Will fix.

ro: No, one of those should be i386. Will fix.
// FUNCTION-SOLARIS: "-fsanitize=function"
// RUN: %clang -target x86_64-scei-ps4 -fsanitize=function -fsanitize=undefined %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-FSAN-UBSAN-PS4 // RUN: %clang -target x86_64-scei-ps4 -fsanitize=function -fsanitize=undefined %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-FSAN-UBSAN-PS4
// CHECK-FSAN-UBSAN-PS4: unsupported option '-fsanitize=function' for target 'x86_64-scei-ps4' // CHECK-FSAN-UBSAN-PS4: unsupported option '-fsanitize=function' for target 'x86_64-scei-ps4'
// RUN: %clang -target x86_64-scei-ps4 -fsanitize=function %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-FSAN-PS4 // RUN: %clang -target x86_64-scei-ps4 -fsanitize=function %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-FSAN-PS4
// CHECK-FSAN-PS4: unsupported option '-fsanitize=function' for target 'x86_64-scei-ps4' // CHECK-FSAN-PS4: unsupported option '-fsanitize=function' for target 'x86_64-scei-ps4'
// RUN: %clang -target x86_64-scei-ps4 -fsanitize=dataflow %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-DFSAN-PS4 // RUN: %clang -target x86_64-scei-ps4 -fsanitize=dataflow %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-DFSAN-PS4
// CHECK-DFSAN-PS4: unsupported option '-fsanitize=dataflow' for target 'x86_64-scei-ps4' // CHECK-DFSAN-PS4: unsupported option '-fsanitize=dataflow' for target 'x86_64-scei-ps4'
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines