Page MenuHomePhabricator

[CMake] Add -z defs on Solaris
ClosedPublic

Authored by ro on Jul 10 2019, 6:42 AM.

Details

Summary

Like other ELF targets, shared objects should be linked with -z defs on Solaris.

Tested on x86_64-pc-solaris2.11 and sparcv9-sun-solaris2.11. Ok for trunk?

Diff Detail

Repository
rL LLVM

Event Timeline

ro created this revision.Jul 10 2019, 6:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2019, 6:42 AM

Ping? It's been a week and this seems pretty obvious, bringing Solaris in line with other ELF targets.

ro added a comment.Tue, Jul 23, 4:19 AM

Ping^2? Two weeks now for a pretty obvious patch.

jyknight accepted this revision.Tue, Jul 23, 7:07 AM
This revision is now accepted and ready to land.Tue, Jul 23, 7:07 AM
Closed by commit rL366821: [CMake] Add -z defs on Solaris (authored by ro, committed by ). · Explain WhyTue, Jul 23, 9:27 AM
This revision was automatically updated to reflect the committed changes.