This is an archive of the discontinued LLVM Phabricator instance.

[lld] [NFC] Match new variable names in comments
AbandonedPublic

Authored by abrachet on Jul 10 2019, 4:04 AM.

Details

Summary

rL365595 changed variables to start with a lower case letter, this change updates comments which declare the parameter to which a constant refers. Also, this patch normalizes such comments so they are in the form /*parameter=*/<value> as shown in the style guide.

Diff Detail

Event Timeline

abrachet created this revision.Jul 10 2019, 4:04 AM
abrachet marked 3 inline comments as done.Jul 10 2019, 4:07 AM
abrachet added inline comments.
lld/ELF/DriverUtils.cpp
149

These parameters have been unchanged it exists in include/Option here.

lld/ELF/LTO.cpp
122

Also has been unchanged, still UseInputModulePath.

223

Again unchanged, still exists as HaveGVs

abrachet retitled this revision from [lld] [NFC] Match to [lld] [NFC] Match new variable names in comments.Jul 10 2019, 4:07 AM
ruiu added inline comments.Jul 10 2019, 4:25 AM
lld/ELF/DWARF.cpp
62

Can you simply /**/ so that a becomes a paramter?

68–69

Ditto

abrachet updated this revision to Diff 208921.Jul 10 2019, 4:57 AM

Uncommented unnamed parameter.

abrachet marked 2 inline comments as done.Jul 10 2019, 4:58 AM
ruiu accepted this revision.Jul 10 2019, 5:21 AM

LGTM

Thanks!

This revision is now accepted and ready to land.Jul 10 2019, 5:21 AM
abrachet abandoned this revision.Jul 18 2019, 7:45 PM

Never got around to pushing this, oops. Looks like these were changed programmatically anyway.