Page MenuHomePhabricator

[unittest] Add bogus register info.
ClosedPublic

Authored by hliao on Jul 9 2019, 8:20 AM.

Details

Summary

Hi Matt

Could you help me review this?

Thanks

  • Michael

Diff Detail

Repository
rL LLVM

Event Timeline

hliao created this revision.Jul 9 2019, 8:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2019, 8:20 AM
dstenb added a comment.Jul 9 2019, 8:42 AM

Thanks a lot for putting the patch together so fast!

I'm not really very familiar around these tests, so I don't know if I can give any valuable input about the patch's contents. It seems reasonable (with my quite limited understanding of this).

hliao edited the summary of this revision. (Show Details)Jul 9 2019, 9:03 AM
hliao added a reviewer: arsenm.
arsenm accepted this revision.Jul 9 2019, 10:12 AM

LGTM, although these should probably be the default implementations anyway

This revision is now accepted and ready to land.Jul 9 2019, 10:12 AM
hliao added a comment.Jul 9 2019, 10:18 AM

LGTM, although these should probably be the default implementations anyway

coud you elaborate in details on the default implementations?

This revision was automatically updated to reflect the committed changes.