Page MenuHomePhabricator

[MIPS GlobalISel] Select float and double phi
ClosedPublic

Authored by Petar.Avramovic on Jul 9 2019, 8:13 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

Petar.Avramovic created this revision.Jul 9 2019, 8:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2019, 8:13 AM
atanasyan accepted this revision.Jul 10 2019, 3:12 AM

LGTM with a nit

lib/Target/Mips/MipsInstructionSelector.cpp
122 ↗(On Diff #208689)

Is "\n" really necessary here?

This revision is now accepted and ready to land.Jul 10 2019, 3:12 AM

Addressed review comments.

Petar.Avramovic marked an inline comment as done.Jul 10 2019, 6:09 AM
This revision was automatically updated to reflect the committed changes.