Page MenuHomePhabricator

[MIPS GlobalISel] Select float and double load and store
ClosedPublic

Authored by Petar.Avramovic on Jul 9 2019, 8:12 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

Petar.Avramovic created this revision.Jul 9 2019, 8:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2019, 8:12 AM
atanasyan accepted this revision.Jul 10 2019, 3:12 AM

LGTM with a nit

lib/Target/Mips/MipsInstructionSelector.cpp
284 ↗(On Diff #208687)

Let's split this complicated condition

if (DestRegBank == Mips::GPRBRegBankID && OpSize != 32)
  return false;

if (DestRegBank == Mips::FPRBRegBankID && OpSize != 32 && OpSize != 64)
  return false;
This revision is now accepted and ready to land.Jul 10 2019, 3:12 AM

Addressed review comments.

Petar.Avramovic marked an inline comment as done.Jul 10 2019, 5:26 AM
This revision was automatically updated to reflect the committed changes.