Explicitly define __STDC_FORMAT_MACROS for PRIu64

[DTharun]

Summary

Builds are failing on RHEL machines because of PRIu64.

lvm/projects/compiler-rt/lib/gwp_asan/guarded_pool_allocator.cpp:420:50: error: expected ')'

snprintf(ThreadBuffer, kThreadBufferLen, "%" PRIu64, ThreadID);

inttypes.h in RHEL uses PRIu64 macros only when __STDC_FORMAT_MACROS is defined.

[hctim]

Thanks for catching this. LGTM.

[DTharun]

In D64388#1579141, @hctim wrote:

Thanks for catching this. LGTM.

I don't have commit rights, please submit the patch.

[lebedev.ri]

compiler-rt/trunk/lib/gwp_asan/guarded_pool_allocator.cpp

14

How do you know it wasn't included before somewhere, by some previous header?
This i think normally should be solved by adding -D__STDC_FORMAT_MACROS to compile command.

[hctim]

compiler-rt/trunk/lib/gwp_asan/guarded_pool_allocator.cpp

14

So it looks like LLVM handles this through add_definitions( -D__STDC_FORMAT_MACROS ), but subprojects (openmp) does this in the same way as this patch (openmp/runtime/test/ompt/callback.h:6).

I personally like the former, so I'll follow up with a revert + fix later today.

compiler-rt/trunk/lib/gwp_asan/guarded_pool_allocator.cpp

 //===-- guarded_pool_allocator.cpp ------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #include "gwp_asan/guarded_pool_allocator.h"
 
 #include "gwp_asan/options.h"
 
+// RHEL creates the PRIu64 format macro (for printing uint64_t's) only when this
+// macro is defined before including <inttypes.h>.
+#ifndef __STDC_FORMAT_MACROS
+  #define __STDC_FORMAT_MACROS 1
+#endif
+
 #include <assert.h>
 #include <inttypes.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <time.h>
 
 using AllocationMetadata = gwp_asan::GuardedPoolAllocator::AllocationMetadata;