libc++: integral types trap on PNaCl

[dschuff]

LGTM

[danalbert]

LGTM.

[jfb]

Rebase, fix repo issue.

[jfb]

Committed as r222842.

[EricWF]

Any opposition for this being included 3.5.1?

/Eric

[jfb]

Committed as r222842.

In D6411#14, @EricWF wrote:

Any opposition for this being included 3.5.1?

/Eric

No opposition, but I wouldn't do extra work either since I'm OK on this just being in 3.6 instead.

[jroelofs]

It doesn't really seem to fit the criteria for being in a *.1 release... it's not fixing a regression.

[EricWF]

In previous conversations about the criteria there was some agreement that non-regression bug fixes could be included. I don't think libc++ had any regressions between 3.5 and now. I'm open to only considering regression fixes but I would like some guidance on this issue.

[jroelofs]

In that light, this does seem pretty benign.

[danalbert]

In D6411#19, @EricWF wrote:

I don't think libc++ had any regressions between 3.5 and now.

Didn't you fix an ASAN failure?

[EricWF]

In D6411#21, @danalbert wrote:

In D6411#19, @EricWF wrote:

I don't think libc++ had any regressions between 3.5 and now.

Didn't you fix an ASAN failure?

The one in <vector>? Yes. I guess that would be a regression. Thanks.

include/limits

protected:
     _LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type quiet_NaN() _NOEXCEPT {return type(0);}
     _LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type signaling_NaN() _NOEXCEPT {return type(0);}
     _LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type denorm_min() _NOEXCEPT {return type(0);}
 
     static _LIBCPP_CONSTEXPR const bool is_iec559 = false;
     static _LIBCPP_CONSTEXPR const bool is_bounded = true;
     static _LIBCPP_CONSTEXPR const bool is_modulo = !_VSTD::is_signed<_Tp>::value;
 
-#if __i386__ || __x86_64__
+#if defined(__i386__) || defined(__x86_64__) || defined(__pnacl__)
     static _LIBCPP_CONSTEXPR const bool traps = true;
 #else
     static _LIBCPP_CONSTEXPR const bool traps = false;
 #endif
     static _LIBCPP_CONSTEXPR const bool tinyness_before = false;
     static _LIBCPP_CONSTEXPR const float_round_style round_style = round_toward_zero;
 };
 

test/language.support/support.limits/limits/numeric.limits.members/traps.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 // test numeric_limits
 
 // traps
 
 #include <limits>
 
-#if (defined(__i386__) || defined(__x86_64__))
+#if defined(__i386__) || defined(__x86_64__) || defined(__pnacl__)
 static const bool integral_types_trap = true;
 #else
 static const bool integral_types_trap = false;
 #endif
 
 template <class T, bool expected>
 void
 test()