[WebAssembly][NFC] simplify SjLj inline assembly test

[quantum]

Summary

Per feedback in D64115, simplify the test.

hidden is left in though, because every test in the file has it.

[aheejin]

Hmm right, every other function has hidden... while you're on a roll, can you remove all hiddens here? :) Thanks!

[aheejin]

llvm/test/CodeGen/WebAssembly/lower-em-sjlj.ll

198 ↗

(On Diff #207686)

Oh one more thing. I think it's better to do
CHECK-NOT: invoke void blah blah
so that what this test is looking for. And maybe add a one-line comment that inline asms should NOT be transformed into invoke wrappers.

[aheejin]

llvm/test/CodeGen/WebAssembly/lower-em-sjlj.ll

198 ↗

(On Diff #207686)

so that what this test is looking for -> so that it is clear what this is looking for

[quantum]

llvm/test/CodeGen/WebAssembly/lower-em-sjlj.ll

198 ↗

(On Diff #207686)

If it generated an invoke wrapper, opt would exit with a failure. I'll put the CHECK-NOT in anyways to make it more explicit.

[quantum]

Add comments and CHECK-NOT: __invoke_void

[aheejin]

In D64117#1567697, @aheejin wrote:

Hmm right, every other function has hidden... while you're on a roll, can you remove all hiddens here? :) Thanks!

Friendly ping. Next time, if you don't want to make some changes I suggested, could you please not just ignore it but rather let me know why you don't want that? This is really nothing, so I'm not asking you to upload this in a separate patch or anything so nevermind about this, but I noticed this pattern a few times now, so I'd just mention this. Thanks for the bugfix again.

[quantum]

@aheejin Sorry, did not see that comment.

llvm/trunk/test/CodeGen/WebAssembly/lower-em-sjlj.ll

entry:
   %arraydecay = getelementptr inbounds [1 x %struct.__jmp_buf_tag], [1 x %struct.__jmp_buf_tag]* %buf, i32 0, i32 0
   call void @longjmp(%struct.__jmp_buf_tag* %arraydecay, i32 5) #1
   unreachable
 ; CHECK: %[[ARRAYDECAY:.*]] = getelementptr inbounds
 ; CHECK-NEXT: call void @emscripten_longjmp_jmpbuf(%struct.__jmp_buf_tag* %[[ARRAYDECAY]], i32 5) #1
 }
 
 ; Test inline asm handling
-define hidden void @inline_asm() #0 {
+define hidden void @inline_asm() {
 ; CHECK-LABEL: @inline_asm
 entry:
   %env = alloca [1 x %struct.__jmp_buf_tag], align 16
   %arraydecay = getelementptr inbounds [1 x %struct.__jmp_buf_tag], [1 x %struct.__jmp_buf_tag]* %env, i32 0, i32 0
   %call = call i32 @setjmp(%struct.__jmp_buf_tag* %arraydecay) #4
-  %cmp = icmp eq i32 %call, 0
-  br i1 %cmp, label %if.then, label %if.else
-
-if.then:                                          ; preds = %entry
+; Inline assembly should not generate __invoke wrappers.
+; Doing so would fail as inline assembly cannot be passed as a function pointer.
 ; CHECK: call void asm sideeffect "", ""()
+; CHECK-NOT: __invoke_void
   call void asm sideeffect "", ""()
-  %arraydecay1 = getelementptr inbounds [1 x %struct.__jmp_buf_tag], [1 x %struct.__jmp_buf_tag]* %env, i32 0, i32 0
-  call void @longjmp(%struct.__jmp_buf_tag* %arraydecay1, i32 1) #5
-  unreachable
-
-if.else:                                          ; preds = %entry
   ret void
 }
 
 declare void @foo()
 ; Function Attrs: returns_twice
 declare i32 @setjmp(%struct.__jmp_buf_tag*) #0
 ; Function Attrs: noreturn
 declare void @longjmp(%struct.__jmp_buf_tag*, i32) #1