AMDGPU: Add missing code for GDS

[nhaehnle]

Summary

Is this needed?

[arsenm]

lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp

59–67 ↗

(On Diff #207663)

This is needed, but needs tests in test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll

lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp

140–153 ↗

(On Diff #207663)

This is not needed

[nhaehnle]

I'm taking this over.

[nhaehnle]

Add test case and remove the legalizer part.

[arsenm]

test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll

56 ↗

(On Diff #210122)

Extra indentation for these

[nhaehnle]

test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll

56 ↗

(On Diff #210122)

Fixing this before commit.

llvm/trunk/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp

 
 void AMDGPUAAWrapperPass::getAnalysisUsage(AnalysisUsage &AU) const {
   AU.setPreservesAll();
 }
 
 // These arrays are indexed by address space value enum elements 0 ... to 7
 static const AliasResult ASAliasRules[8][8] = {
   /*                    Flat       Global    Region    Group     Constant  Private   Constant 32-bit  Buffer Fat Ptr */
-  /* Flat     */        {MayAlias, MayAlias, MayAlias, MayAlias, MayAlias, MayAlias, MayAlias,        MayAlias},
+  /* Flat     */        {MayAlias, MayAlias, NoAlias,  MayAlias, MayAlias, MayAlias, MayAlias,        MayAlias},
   /* Global   */        {MayAlias, MayAlias, NoAlias , NoAlias , MayAlias, NoAlias , MayAlias,        MayAlias},
-  /* Region   */        {MayAlias, NoAlias , NoAlias , NoAlias , MayAlias, NoAlias , MayAlias,        NoAlias},
+  /* Region   */        {NoAlias,  NoAlias , MayAlias, NoAlias , NoAlias,  NoAlias , NoAlias,         NoAlias},
   /* Group    */        {MayAlias, NoAlias , NoAlias , MayAlias, NoAlias , NoAlias , NoAlias ,        NoAlias},
-  /* Constant */        {MayAlias, MayAlias, MayAlias, NoAlias , NoAlias , NoAlias , MayAlias,        MayAlias},
+  /* Constant */        {MayAlias, MayAlias, NoAlias,  NoAlias , NoAlias , NoAlias , MayAlias,        MayAlias},
   /* Private  */        {MayAlias, NoAlias , NoAlias , NoAlias , NoAlias , MayAlias, NoAlias ,        NoAlias},
-  /* Constant 32-bit */ {MayAlias, MayAlias, MayAlias, NoAlias , MayAlias, NoAlias , NoAlias ,        MayAlias},
+  /* Constant 32-bit */ {MayAlias, MayAlias, NoAlias,  NoAlias , MayAlias, NoAlias , NoAlias ,        MayAlias},
   /* Buffer Fat Ptr  */ {MayAlias, MayAlias, NoAlias , NoAlias , MayAlias, NoAlias , MayAlias,        MayAlias}
 };
 
 static AliasResult getAliasResult(unsigned AS1, unsigned AS2) {
   static_assert(AMDGPUAS::MAX_AMDGPU_ADDRESS <= 7, "Addr space out of range");
 
   if (AS1 > AMDGPUAS::MAX_AMDGPU_ADDRESS || AS2 > AMDGPUAS::MAX_AMDGPU_ADDRESS)
     return MayAlias;

llvm/trunk/test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll

define void @test_1_999(i8 addrspace(1)* %p, i8 addrspace(999)* %p1) {
   ret void
 }
 
 ; CHECK: MayAlias:  i8 addrspace(1)* %p1, i8 addrspace(999)* %p
 define void @test_999_1(i8 addrspace(999)* %p, i8 addrspace(1)* %p1) {
   ret void
 }
 
+; CHECK: NoAlias:  i8 addrspace(2)* %p, i8* %p1
+define void @test_region_vs_flat(i8 addrspace(2)* %p, i8 addrspace(0)* %p1) {
+  ret void
+}
+
+; CHECK: NoAlias:  i8 addrspace(1)* %p1, i8 addrspace(2)* %p
+define void @test_region_vs_global(i8 addrspace(2)* %p, i8 addrspace(1)* %p1) {
+  ret void
+}
+
+; CHECK: MayAlias: i8 addrspace(2)* %p, i8 addrspace(2)* %p1
+define void @test_region(i8 addrspace(2)* %p, i8 addrspace(2)* %p1) {
+  ret void
+}
+
+; CHECK: NoAlias:  i8 addrspace(2)* %p, i8 addrspace(3)* %p1
+define void @test_region_vs_group(i8 addrspace(2)* %p, i8 addrspace(3)* %p1) {
+  ret void
+}
+
+; CHECK: NoAlias:  i8 addrspace(2)* %p, i8 addrspace(4)* %p1
+define void @test_region_vs_constant(i8 addrspace(2)* %p, i8 addrspace(4)* %p1) {
+  ret void
+}
+
+; CHECK: NoAlias:  i8 addrspace(2)* %p, i8 addrspace(5)* %p1
+define void @test_region_vs_private(i8 addrspace(2)* %p, i8 addrspace(5)* %p1) {
+  ret void
+}
+
+; CHECK: NoAlias:  i8 addrspace(2)* %p, i8 addrspace(6)* %p1
+define void @test_region_vs_const32(i8 addrspace(2)* %p, i8 addrspace(6)* %p1) {
+  ret void
+}
+
 ; CHECK: MayAlias:  i8 addrspace(7)* %p, i8* %p1
 define void @test_7_0(i8 addrspace(7)* %p, i8 addrspace(0)* %p1) {
-    ret void
 }
 
 ; CHECK: MayAlias:  i8 addrspace(1)* %p1, i8 addrspace(7)* %p
 define void @test_7_1(i8 addrspace(7)* %p, i8 addrspace(1)* %p1) {
-    ret void
 }
 
 ; CHECK: NoAlias:  i8 addrspace(2)* %p1, i8 addrspace(7)* %p
 define void @test_7_2(i8 addrspace(7)* %p, i8 addrspace(2)* %p1) {
-    ret void
 }
 
 ; CHECK: NoAlias:  i8 addrspace(3)* %p1, i8 addrspace(7)* %p
 define void @test_7_3(i8 addrspace(7)* %p, i8 addrspace(3)* %p1) {
-    ret void
 }
 
 ; CHECK: MayAlias:  i8 addrspace(4)* %p1, i8 addrspace(7)* %p
 define void @test_7_4(i8 addrspace(7)* %p, i8 addrspace(4)* %p1) {
-    ret void
 }
 
 ; CHECK: NoAlias:  i8 addrspace(5)* %p1, i8 addrspace(7)* %p
 define void @test_7_5(i8 addrspace(7)* %p, i8 addrspace(5)* %p1) {
-    ret void
 }
 
 ; CHECK: MayAlias:  i8 addrspace(6)* %p1, i8 addrspace(7)* %p
 define void @test_7_6(i8 addrspace(7)* %p, i8 addrspace(6)* %p1) {
-    ret void
 }
 
 ; CHECK: MayAlias:  i8 addrspace(7)* %p, i8 addrspace(7)* %p1
 define void @test_7_7(i8 addrspace(7)* %p, i8 addrspace(7)* %p1) {
-    ret void
 }