This is an archive of the discontinued LLVM Phabricator instance.

Standardize on MSVC behavior for triples with no environment
ClosedPublic

Authored by rnk on Jul 2 2019, 3:53 PM.

Details

Summary

This makes it so that IR files using triples without an environment work
out of the box, without normalizing them.

Typically, the MSVC behavior is more desirable. For example, it tends to
enable things like constant merging, use of associative comdats, etc.

Addresses PR42491

Diff Detail

Repository
rL LLVM

Event Timeline

rnk created this revision.Jul 2 2019, 3:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2019, 3:53 PM
compnerd accepted this revision.Jul 5 2019, 9:14 AM

I'm happy to see this finally happening, it makes much more sense.

This revision is now accepted and ready to land.Jul 5 2019, 9:14 AM
rnk added a comment.Jul 8 2019, 2:04 PM

I'm happy to see this finally happening, it makes much more sense.

Thanks! I'm glad we're on the same page, I thought maybe you would oppose this idea. :)

This revision was automatically updated to reflect the committed changes.