Page MenuHomePhabricator

Skip test earlier if metric is not found in compare.py
ClosedPublic

Authored by fhahn on Jul 2 2019, 4:03 AM.

Details

Summary

This speeds up processing for inputs with lots of missing metrics, by
avoiding adding them to names.

Diff Detail

Repository
rL LLVM

Event Timeline

fhahn created this revision.Jul 2 2019, 4:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2019, 4:03 AM
utils/compare.py
37 ↗(On Diff #207509)

I don't know if it's relevant, but a missing metrics *and* empty or duplicate name would no longer raise an Exception; it's probably better to continue right after the sanity checks?

fhahn updated this revision to Diff 207547.Jul 2 2019, 6:38 AM

Move metric check after name validation, thanks!

fhahn marked 2 inline comments as done.Jul 2 2019, 6:38 AM
fhahn added inline comments.
utils/compare.py
37 ↗(On Diff #207509)

Yep, it should be after the name validation, thanks

LGTM then, please get another feedback though, I'm not comfortable with that code area

fhahn marked an inline comment as done.Jul 10 2019, 7:59 AM

ping

cmatthews resigned from this revision.Jul 10 2019, 10:54 AM

Any chance you could have a quick look Jessica?

This revision is now accepted and ready to land.Tue, Jul 23, 2:07 PM
This revision was automatically updated to reflect the committed changes.