[CXX] Exercise all paths through these tests

[probinson]

Summary

These 3 tests have dialect-based conditionals, but weren't running Clang with enough different dialects to actually enable those conditional sections.

[probinson]

Ping. This is pretty straightforward, the only question is whether we want to preserve these older-dialect tests or rip them out.

[dblaikie]

I would've assumed these conditionals were added by Sony folks for their change in default dialect - that doesn't necessarily mean these tests are needed upstream (the functionality may be tested elsewhere)

[probinson]

In D63894#1574419, @dblaikie wrote:

I would've assumed these conditionals were added by Sony folks for their change in default dialect - that doesn't necessarily mean these tests are needed upstream (the functionality may be tested elsewhere)

For two of the files, the conditionals were added by Richard Smith, not Sony. For the Sony case, it is the *older* path that was upstream originally, and that is the one that the tests stopped testing; there is no reason to think those paths are tested elsewhere.

[probinson]

In D63894#1576288, @probinson wrote:

there is no reason to think those paths are tested elsewhere.

Well that may be a tad strong. But I'm reluctant to remove them unless they are demonstrably tested elsewhere, and it's not clear to me how to look.

[rsmith]

clang/test/SemaCXX/linkage2.cpp

3

Should this one be run in C++98 mode too? (The use of -Wno-c++11-extensions suggests to me that C++98 was expected.)

[probinson]

clang/test/SemaCXX/linkage2.cpp

3

I don't think so; -Wno-c++11-extensions will not suppress diagnostics about GNU extensions. I think GNU++98 is what's wanted here (and is the old default dialect).

clang/test/CXX/dcl.dcl/basic.namespace/namespace.udecl/p4.cpp

 // RUN: %clang_cc1 -fsyntax-only -verify %s
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c++98 %s
 // RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 %s
 
 // C++03 [namespace.udecl]p4:
 //   A using-declaration used as a member-declaration shall refer to a
 //   member of a base class of the class being defined, shall refer to
 //   a member of an anonymous union that is a member of a base class
 //   of the class being defined, or shall refer to an enumerator for
 //   an enumeration type that is a member of a base class of the class

clang/test/SemaCXX/class.cpp

 // RUN: %clang_cc1 -fsyntax-only -verify -Wc++11-compat %s 
+// RUN: %clang_cc1 -fsyntax-only -verify -Wc++11-compat %s -std=c++98
 class C {
 public:
   auto int errx; // expected-error {{storage class specified for a member declaration}}
 #if __cplusplus <= 199711L
   // expected-warning@-2 {{'auto' storage class specifier is redundant}}
 #else
   // expected-warning@-4 {{'auto' storage class specifier is not permitted in C++11, and will not be supported in future releases}}
 #endif

clang/test/SemaCXX/linkage2.cpp

 // RUN: %clang_cc1 -fsyntax-only -verify -std=gnu++11 %s
-// RUN: %clang_cc1 -fsyntax-only -verify -Wno-c++11-extensions -Wno-local-type-template-args %s
+// RUN: %clang_cc1 -fsyntax-only -verify -Wno-c++11-extensions -Wno-local-type-template-args %s -std=gnu++98
 // RUN: %clang_cc1 -fsyntax-only -verify -Wno-c++11-extensions -Wno-local-type-template-args -fmodules %s
 
 namespace test1 {
   int x; // expected-note {{previous definition is here}}
   static int y;
   void f() {} // expected-note {{previous definition is here}}
 
   extern "C" {
     extern int x; // expected-error {{declaration of 'x' has a different language linkage}}