This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Fix allowing non-boolean conditions for G_SELECT
ClosedPublic

Authored by arsenm on Jun 25 2019, 5:48 PM.

Details

Reviewers
tstellar
nhaehnle
Summary

The condition register bank must be scc or vcc so that a copy will be
inserted, which will be lowered to a compare.

Currently greedy unnecessarily forces using a VCC select.

Diff Detail

Event Timeline

arsenm created this revision.Jun 25 2019, 5:48 PM
nhaehnle accepted this revision.Jul 1 2019, 2:45 AM

LGTM

This revision is now accepted and ready to land.Jul 1 2019, 2:45 AM
arsenm closed this revision.Jul 1 2019, 11:13 AM

r364825