This is an archive of the discontinued LLVM Phabricator instance.

Add USan+ASan and UBSan+TSan tests to shadow-memory lit parallelism group.
ClosedPublic

Authored by delcypher on Jun 25 2019, 4:43 PM.

Details

Summary

Previously we were running these tests without the "shadow-memory"
lit parallelism group even though we run the ASan and TSan tests in
this group to avoid problems with many processes using shadow memory
in parallel.

On my local machine the UBSan+TSan tests would previously timeout
if I set a 30 second per test limit. With this change I no longer
see individual test timeouts.

This change was made in response to the greendragon build bot reporting
individual test timeouts for these tests. Given that the UBSan+ASan and
UBSan+TSan tests did not have a parallelism group previously it's likely
that some other change has caused the performance degradation. However
I haven't been able to track down the cause so until we do, this change
seems reasonable and is in line with what we already do with ASan and
TSan tests.

rdar://problem/51754620

Diff Detail

Repository
rL LLVM

Event Timeline

delcypher created this revision.Jun 25 2019, 4:43 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 25 2019, 4:43 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
yln accepted this revision.Jun 25 2019, 5:12 PM

LGTM with 1 nit.
Thanks! I thought I also did this for UBSan+xxx, but apparently I forgot.

compiler-rt/test/ubsan/lit.common.cfg
78 ↗(On Diff #206549)

if ubsan_lit_test_mode in ['AddressSanitizer', 'MemorySanitizer', 'ThreadSanitizer']:

This revision is now accepted and ready to land.Jun 25 2019, 5:12 PM
This revision was automatically updated to reflect the committed changes.
delcypher marked an inline comment as done.Jun 25 2019, 5:47 PM
delcypher added inline comments.
compiler-rt/test/ubsan/lit.common.cfg
78 ↗(On Diff #206549)

Oops I missed this. I'll do this as a follow up commit.

delcypher marked an inline comment as done.Jun 25 2019, 5:56 PM
delcypher added inline comments.
compiler-rt/test/ubsan/lit.common.cfg
78 ↗(On Diff #206549)

@yln Landed a follow up fix in r364369.