This is an archive of the discontinued LLVM Phabricator instance.

Differential D63737

[WebAssembly] Remove catch_all from AsmParser
ClosedPublic

Authored by aheejin on Jun 24 2019, 1:14 PM.

Details

Reviewers
aardappel
Commits
rG65d8d6357b81: [WebAssembly] Remove catch_all from AsmParser
rL364360: [WebAssembly] Remove catch_all from AsmParser
Summary

catch_all is from the first version of EH proposal and now has been
removed. There were no tests covering this, and thus no tests to remove
or fix.

Diff Detail

Event Timeline

aheejin created this revision.Jun 24 2019, 1:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2019, 1:14 PM
Herald added subscribers: llvm-commits, sunfish, jgravelle-google and 2 others. · View Herald Transcript
Harbormaster completed remote builds in B33819: Diff 206289.Jun 24 2019, 1:18 PM
aardappel accepted this revision.Jun 24 2019, 4:07 PM
This revision is now accepted and ready to land.Jun 24 2019, 4:07 PM
Closed by commit rL364360: [WebAssembly] Remove catch_all from AsmParser (authored by aheejin). · Explain WhyJun 25 2019, 4:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
WebAssembly/
AsmParser/
4 lines

Diff 206289

lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp

Show First 20 Lines • Show All 427 Lines • ▼ Show 20 Lines bool ParseInstruction(ParseInstructionInfo & /*Info*/, StringRef Name,
} else if (BaseName == "else") { } else if (BaseName == "else") {
if (pop(BaseName, If)) if (pop(BaseName, If))
return true; return true;
push(Else); push(Else);
} else if (BaseName == "catch") { } else if (BaseName == "catch") {
if (pop(BaseName, Try)) if (pop(BaseName, Try))
return true; return true;
push(Try); push(Try);
} else if (BaseName == "catch_all") {
if (pop(BaseName, Try))
return true;
push(Try);
} else if (BaseName == "end_if") { } else if (BaseName == "end_if") {
if (pop(BaseName, If, Else)) if (pop(BaseName, If, Else))
return true; return true;
} else if (BaseName == "end_try") { } else if (BaseName == "end_try") {
if (pop(BaseName, Try)) if (pop(BaseName, Try))
return true; return true;
} else if (BaseName == "end_loop") { } else if (BaseName == "end_loop") {
if (pop(BaseName, Loop)) if (pop(BaseName, Loop))
▲ Show 20 Lines • Show All 327 Lines • Show Last 20 Lines